Skip to content

Suggest the path separator when a dot is used on a trait #100367

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

fmease
Copy link
Member

@fmease fmease commented Aug 10, 2022

Fixes #100365.

@rustbot label A-diagnostics
r? diagnostics

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 10, 2022
@rust-highfive
Copy link
Contributor

r? @fee1-dead

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the A-diagnostics Area: Messages for errors, warnings, and lints label Aug 10, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2022
@fmease fmease changed the title Suggest path separator when a dot is used on a trait Suggest the path separator when a dot is used on a trait Aug 10, 2022
@compiler-errors
Copy link
Member

Thanks @fmease !

r=me once that other PR lands and you rebase past it.

@bors delegate+

@bors
Copy link
Collaborator

bors commented Aug 11, 2022

✌️ @fmease can now approve this pull request

@fmease
Copy link
Member Author

fmease commented Aug 11, 2022

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Aug 11, 2022

📌 Commit 0fb4ef6 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 13, 2022
Suggest the path separator when a dot is used on a trait

Fixes rust-lang#100365.

`@rustbot` label A-diagnostics
r? diagnostics
@compiler-errors
Copy link
Member

alleviating pressure on bors queue, since this is just diagnostics changes

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2022
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#99646 (Only point out a single function parameter if we have a single arg incompatibility)
 - rust-lang#100299 (make `clean::Item::span` return `Option` instead of dummy span)
 - rust-lang#100335 (Rustdoc-Json: Add `Path` type for traits.)
 - rust-lang#100367 (Suggest the path separator when a dot is used on a trait)
 - rust-lang#100431 (Enum variant ctor inherits the stability of the enum variant)
 - rust-lang#100446 (Suggest removing a semicolon after impl/trait items)
 - rust-lang#100468 (Use an extensionless `x` script for non-Windows)
 - rust-lang#100479 (Argument type error improvements)

Failed merges:

 - rust-lang#100483 (Point to generic or arg if it's the self type of unsatisfied projection predicate)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e248c7f into rust-lang:master Aug 14, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 14, 2022
@fmease fmease deleted the fix-100365 branch August 14, 2022 12:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling associated methods on traits with . should yield helpful suggestion
6 participants