Enum variant ctor inherits the stability of the enum variant #100431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @dtolnay and libs folks, may be worth revisiting whether we want to inherit stability on things like enum variants in the first place |
|
Second commit is the missing check for why this turned into an ICE instead of an error. |
|
☔ The latest upstream changes (presumably #100426) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me on the changes. I believe the original code might have been buggy (which is why I couldn't land the stability attributes removal from stdlib). |
compiler-errors
force-pushed
the
enum-ctor-variant-stab
branch
from
a503be1 to
6925f41
Compare
I can try to see if we can revive that PR with this change :) |
|
@bors r=estebank |
bors
added
S-waiting-on-bors
|
this is probably low perf risk @bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 14, 2022
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#99646 (Only point out a single function parameter if we have a single arg incompatibility) - rust-lang#100299 (make `clean::Item::span` return `Option` instead of dummy span) - rust-lang#100335 (Rustdoc-Json: Add `Path` type for traits.) - rust-lang#100367 (Suggest the path separator when a dot is used on a trait) - rust-lang#100431 (Enum variant ctor inherits the stability of the enum variant) - rust-lang#100446 (Suggest removing a semicolon after impl/trait items) - rust-lang#100468 (Use an extensionless `x` script for non-Windows) - rust-lang#100479 (Argument type error improvements) Failed merges: - rust-lang#100483 (Point to generic or arg if it's the self type of unsatisfied projection predicate) r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100399
Fixes #100420
Context #71481 for why enum variants don't need stability