Skip to content

Remove manual <[u8]>::escape_ascii #100767

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

Remove manual <[u8]>::escape_ascii #100767

merged 1 commit into from
Sep 12, 2022

Conversation

kadiwa4
Copy link
Contributor

@kadiwa4 kadiwa4 commented Aug 19, 2022

@rustbot label: +C-cleanup

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 19, 2022
@rust-highfive
Copy link
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Aug 19, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2022
@rustbot rustbot added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Aug 19, 2022
@jackh726
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 12, 2022

📌 Commit a297631 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 12, 2022
Merged
@bors
Copy link
Collaborator

bors commented Sep 12, 2022

⌛ Testing commit a297631 with merge 3ed623c47a68b1bfd50c6a377eedd276b447c1ee...

@Dylan-DPC
Copy link
Member

@bors retry yield to rollup

@bors
Copy link
Collaborator

bors commented Sep 12, 2022

⌛ Testing commit a297631 with merge 3bfca4c83ec6bc361ae56dd76507d174f1723fbc...

@bors
Copy link
Collaborator

bors commented Sep 12, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 12, 2022
@Dylan-DPC
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2022
@bors
Auto merge of rust-lang#101716 - Dylan-DPC:rollup-ayvh6nd, r=Dylan-DPC
7f115e3 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#100293 (Add inline-llvm option for disabling/enabling LLVM inlining)
 - rust-lang#100767 (Remove manual <[u8]>::escape_ascii)
 - rust-lang#101668 (Suggest pub instead of public for const type item)
 - rust-lang#101671 (Fix naming format of IEEE 754 standard)
 - rust-lang#101676 (Check that the types in return position `impl Trait` in traits are well-formed)
 - rust-lang#101681 (Deny return-position `impl Trait` in traits for object safety)
 - rust-lang#101693 (Update browser UI test 0 10)
 - rust-lang#101701 (Rustdoc-Json: Add tests for trait impls.)
 - rust-lang#101706 (rustdoc: remove no-op `#search`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9317775 into rust-lang:master Sep 12, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 12, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:2541b1294d2704b0964813337f33b291d3f8596b)
##[warning]Failed to download action 'https://api.github.com/repos/actions/checkout/zipball/2541b1294d2704b0964813337f33b291d3f8596b'. Error: No connection could be made because the target machine actively refused it. (api.github.com:443)
##[warning]Back off 24.464 seconds before retry.
##[warning]Failed to download action 'https://api.github.com/repos/actions/checkout/zipball/2541b1294d2704b0964813337f33b291d3f8596b'. Error: No connection could be made because the target machine actively refused it. (api.github.com:443)
##[warning]Back off 22.279 seconds before retry.
##[error]No connection could be made because the target machine actively refused it. (api.github.com:443)

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@kadiwa4 kadiwa4 deleted the escape_ascii branch September 13, 2022 17:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
7 participants
@kadiwa4 @rust-highfive @rustbot @jackh726 @bors @Dylan-DPC @rust-log-analyzer