Skip to content

Fix naming format of IEEE 754 standard #101671

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

Fix naming format of IEEE 754 standard #101671

merged 1 commit into from
Sep 12, 2022

Conversation

LingMan
Copy link
Contributor

@LingMan LingMan commented Sep 11, 2022

Currently the documentation of f64::min refers to "IEEE-754 2008" while the documentation of f64::minimum refers to "IEEE 754-2019".
Note that one has the format IEEE,hyphen,number,space,year while the other is IEEE,space,number,hyphen,year. The official IEEE site [1] uses the later format and it is also the one most commonly used throughout the codebase.

Update all comments and - more importantly - documentation to consistently use the official format.

[1] https://standards.ieee.org/ieee/754/4211/

@LingMan
Fix naming format of IEEE 754 standard
fd21df7 
Currently the documentation of f64::min refers to "IEEE-754 2008" while the documentation of
f64::minimum refers to "IEEE 754-2019".
Note that one has the format IEEE,hyphen,number,space,year while the other is
IEEE,space,number,hyphen,year. The official IEEE site [1] uses the later format and it is also the
one most commonly used throughout the codebase.

Update all comments and - more importantly - documentation to consistently use the official format.

[1] https://standards.ieee.org/ieee/754/4211/
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 11, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 12, 2022

📌 Commit fd21df7 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 12, 2022
Merged
@bors
Copy link
Collaborator

bors commented Sep 12, 2022

⌛ Testing commit fd21df7 with merge ed766d8f764d62eeeaf4eed3cdd6fa9f5559493d...

@bors
Copy link
Collaborator

bors commented Sep 12, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 12, 2022
@Dylan-DPC
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2022
@bors
Auto merge of rust-lang#101716 - Dylan-DPC:rollup-ayvh6nd, r=Dylan-DPC
7f115e3 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#100293 (Add inline-llvm option for disabling/enabling LLVM inlining)
 - rust-lang#100767 (Remove manual <[u8]>::escape_ascii)
 - rust-lang#101668 (Suggest pub instead of public for const type item)
 - rust-lang#101671 (Fix naming format of IEEE 754 standard)
 - rust-lang#101676 (Check that the types in return position `impl Trait` in traits are well-formed)
 - rust-lang#101681 (Deny return-position `impl Trait` in traits for object safety)
 - rust-lang#101693 (Update browser UI test 0 10)
 - rust-lang#101701 (Rustdoc-Json: Add tests for trait impls.)
 - rust-lang#101706 (rustdoc: remove no-op `#search`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 10af4fb into rust-lang:master Sep 12, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 12, 2022
@LingMan LingMan deleted the ieee_754 branch September 12, 2022 15:58
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
7 participants
@LingMan @rustbot @rust-highfive @Dylan-DPC @bors @rust-log-analyzer @joshtriplett