Skip to content

rustdoc: remove no-op #search #101706

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Sep 12, 2022

The margin rule was added in c729e4d to remove an unnecessary left margin that was present on desktop. This desktop-mode margin was itself removed in 135281e.

The padding rule was added in 135281e when converting the rule for #main, but didn't do anything even then.

This rule was added in c729e4d to remove an
unnecessary left margin that was present on desktop. This desktop-mode margin
was itself removed in 135281e.
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 12, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive
Copy link
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2022
@notriddle notriddle changed the title rustdoc: remove no-op #search { margin-left: 0 } rustdoc: remove no-op #search Sep 12, 2022
The padding rule was added in 135281e when
converting the rule for #main, but didn't do anything even then.
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 12, 2022

📌 Commit 2d239fb has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2022
Rollup of 9 pull requests

Successful merges:

 - rust-lang#100293 (Add inline-llvm option for disabling/enabling LLVM inlining)
 - rust-lang#100767 (Remove manual <[u8]>::escape_ascii)
 - rust-lang#101668 (Suggest pub instead of public for const type item)
 - rust-lang#101671 (Fix naming format of IEEE 754 standard)
 - rust-lang#101676 (Check that the types in return position `impl Trait` in traits are well-formed)
 - rust-lang#101681 (Deny return-position `impl Trait` in traits for object safety)
 - rust-lang#101693 (Update browser UI test 0 10)
 - rust-lang#101701 (Rustdoc-Json: Add tests for trait impls.)
 - rust-lang#101706 (rustdoc: remove no-op `#search`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9bf89e7 into rust-lang:master Sep 12, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 12, 2022
@notriddle notriddle deleted the notriddle/search-mobile branch September 12, 2022 16:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants