Skip to content

rustdoc: remove unused CSS .content .item-list #102744

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2022
Merged

rustdoc: remove unused CSS .content .item-list #102744

merged 2 commits into from
Oct 7, 2022

Conversation

notriddle
Copy link
Contributor

When these rules were added in 4fd061c (yeah, that's the very first commit of rustdoc_ng), .item-list was a <ul>, and this would override the default style for that tag.

In c1b1d68, it was changed to use a <div> tag, so these rules are both no-ops.

@notriddle
rustdoc: remove unused CSS .content .item-list
50f662e 
When these rules were added in 4fd061c
(yeah, that's the very first commit of rustdoc_ng), `.item-list` was a
`<ul>`, and this would override the default style for that tag.

In c1b1d68, it was changed to use a
`<div>` tag, so these rules are both no-ops.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 6, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2022
@GuillaumeGomez
Copy link
Member

Less CSS and less HTML. \o/

r=me once CI pass

@notriddle
rustdoc: remove unused HTML class="item-list"
0997b28 
Since 50f662e, there is no CSS or JS
targeting this class.
@notriddle notriddle force-pushed the notriddle/content-item-list branch from ea2144d to 0997b28 Compare October 6, 2022 17:55
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between 2d46584fae1acc74566bf49fce976fe509a38f5f and 37bb2b5afe301fd30477d205c7139ba9f9f6a829
Rustdoc was updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
.......... (70/77)
.......    (77/77)


/checkout/src/test/rustdoc-gui/basic-code.goml basic-code... FAILED
[ERROR] (line 3) expected 1 elements, found 0: for command `assert-count: (".src-line-numbers", 1)`
Build completed unsuccessfully in 0:02:16

@notriddle
Copy link
Contributor Author

Is https://github.com/rust-lang/rust/actions/runs/3199349362/jobs/5225001335#step:25:4065 an intermittent test failure? @GuillaumeGomez I can't reproduce the fail locally.

@GuillaumeGomez
Copy link
Member

Seems very unlikely since the DOM is fully loaded before this check is performed. How strange... Let's retry and if the CI pass, I'll add a mental note to check what happened.

@notriddle
Copy link
Contributor Author

@GuillaumeGomez It passed.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 6, 2022
Open
@GuillaumeGomez
Copy link
Member

I commented about it in #93784. Let's move forward for the current one.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 6, 2022

📌 Commit 0997b28 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 7, 2022
@matthiaskrgr
Rollup merge of rust-lang#102744 - notriddle:notriddle/content-item-l…
9e79af3 
…ist, r=GuillaumeGomez

rustdoc: remove unused CSS `.content .item-list`

When these rules were added in 4fd061c (yeah, that's the very first commit of rustdoc_ng), `.item-list` was a `<ul>`, and this would override the default style for that tag.

In c1b1d68, it was changed to use a `<div>` tag, so these rules are both no-ops.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 7, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 7, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2022
@bors
Auto merge of rust-lang#102767 - matthiaskrgr:rollup-vcbt81v, r=matth…
5854680 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#102577 (Warn about Visual Studio Code branding confusion)
 - rust-lang#102720 (do not reverse the expected type and found type for ObligationCauseCo…)
 - rust-lang#102744 (rustdoc: remove unused CSS `.content .item-list`)
 - rust-lang#102747 (rustdoc: remove unused CSS `.docblock a:not(.srclink)`)
 - rust-lang#102748 (Disable compressed debug sections on i586-gnu)
 - rust-lang#102761 (let-else: test else block with non-never uninhabited type)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a636398 into rust-lang:master Oct 7, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 7, 2022
@notriddle notriddle deleted the notriddle/content-item-list branch October 7, 2022 14:06
@dtolnay dtolnay mentioned this pull request Oct 7, 2022
Merged
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 14, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#103047 - GuillaumeGomez:update-browser-ui-t…
8bbea38 
…est, r=notriddle

Update browser-ui-test version to fix some flaky tests

Part of rust-lang#93784.

It should fix the new spurious failure found in rust-lang#102744.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#103047 - GuillaumeGomez:update-browser-ui-t…
fa1279f 
…est, r=notriddle

Update browser-ui-test version to fix some flaky tests

Part of rust-lang#93784.

It should fix the new spurious failure found in rust-lang#102744.

r? ``@notriddle``
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@CraftSpider CraftSpider

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
7 participants
@notriddle @rust-highfive @rustbot @GuillaumeGomez @rust-log-analyzer @bors @CraftSpider