Skip to content

Disable compressed debug sections on i586-gnu #102748

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Oct 6, 2022

Compressed debug is enabled by default for gas (assembly) on Linux/x86
targets, and we started building our own in #102530, but that made our
compiler_builtins incompatible with binutils < 2.32. Add an explicit
option to disable that in our crosstool-ng config. Fixes #102703.

Compressed debug is enabled by default for gas (assembly) on Linux/x86
targets, and we started building our own in rust-lang#102530, but that made our
`compiler_builtins` incompatible with binutils < 2.32. Add an explicit
option to disable that in our crosstool-ng config. Fixes rust-lang#102703.
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Oct 6, 2022
@rust-highfive
Copy link
Contributor

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2022
@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 6, 2022

📌 Commit 1158398 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 7, 2022
…troalbini

Disable compressed debug sections on i586-gnu

Compressed debug is enabled by default for gas (assembly) on Linux/x86
targets, and we started building our own in rust-lang#102530, but that made our
`compiler_builtins` incompatible with binutils < 2.32. Add an explicit
option to disable that in our crosstool-ng config. Fixes rust-lang#102703.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#102577 (Warn about Visual Studio Code branding confusion)
 - rust-lang#102720 (do not reverse the expected type and found type for ObligationCauseCo…)
 - rust-lang#102744 (rustdoc: remove unused CSS `.content .item-list`)
 - rust-lang#102747 (rustdoc: remove unused CSS `.docblock a:not(.srclink)`)
 - rust-lang#102748 (Disable compressed debug sections on i586-gnu)
 - rust-lang#102761 (let-else: test else block with non-never uninhabited type)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 04459f7 into rust-lang:master Oct 7, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 7, 2022
@cuviper cuviper deleted the i586-gnu-uncompress branch October 15, 2022 00:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hashbrown tests fail on Rust / test (ubuntu-latest, i586-unknown-linux-gnu, nightly)
5 participants