Skip to content

rustdoc: remove unused CSS .docblock a:not(.srclink) #102747

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Oct 6, 2022

This selector was added in c7312fb, because the list of impl items could be nested below docblock.

if !show_def_docs {
write!(w, "<span class='docblock autohide'>")?;
}
write!(w, "<div class='impl-items'>")?;

Now that rustdoc toggles have been switched to <details>, there shouldn't be any need to put things inside docblock containers just to give them disclosure toggles.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 6, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2022
This selector was added in c7312fb,
because the list of impl items could be nested below `docblock`.

https://github.com/rust-lang/rust/blob/c7312fbae4979c6d4fdfbd1f55a71cd47d82a480/src/librustdoc/html/render.rs#L3841-L3845

Now that rustdoc toggles have been switched to `<details>`, there shouldn't
be any need to put things inside docblock containers just to give them
disclosure toggles.
@notriddle notriddle force-pushed the notriddle/docblock-a-not-srclink branch from 82bdf96 to 28b26b7 Compare October 6, 2022 18:21
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Oct 6, 2022

📌 Commit 28b26b7 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 7, 2022
…-srclink, r=GuillaumeGomez

rustdoc: remove unused CSS `.docblock a:not(.srclink)`

This selector was added in c7312fb, because the list of impl items could be nested below `docblock`.

https://github.com/rust-lang/rust/blob/c7312fbae4979c6d4fdfbd1f55a71cd47d82a480/src/librustdoc/html/render.rs#L3841-L3845

Now that rustdoc toggles have been switched to `<details>`, there shouldn't be any need to put things inside docblock containers just to give them disclosure toggles.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#102577 (Warn about Visual Studio Code branding confusion)
 - rust-lang#102720 (do not reverse the expected type and found type for ObligationCauseCo…)
 - rust-lang#102744 (rustdoc: remove unused CSS `.content .item-list`)
 - rust-lang#102747 (rustdoc: remove unused CSS `.docblock a:not(.srclink)`)
 - rust-lang#102748 (Disable compressed debug sections on i586-gnu)
 - rust-lang#102761 (let-else: test else block with non-never uninhabited type)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d6c05fb into rust-lang:master Oct 7, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 7, 2022
@notriddle notriddle deleted the notriddle/docblock-a-not-srclink branch October 7, 2022 14:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants