-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix re-export of doc hidden macro not showing up #111997
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix re-export of doc hidden macro not showing up #111997
Conversation
This comment has been minimized.
This comment has been minimized.
Interestingly enough, bang macros need to be handled a bit differently otherwise you can't re-export the same one with two different names in the same module. How strange. |
This comment has been minimized.
This comment has been minimized.
If a That was under consideration in #109697, but the FCP never finished, and the issue was closed. Having re-exported |
They are not. If you have: #[doc(hidden)]
pub struct Foo;
pub use crate::Foo as Bar; Then you'll have in the documentation:
But And I forgot to run |
e313bf2
to
898dfc6
Compare
I need to precise one thing: if you add EDIT: But again, it's the current behaviour, didn't change anything in that regard. This PR is really just fixing a bug on re-export of bang macros. |
Ah, yes. That's what we agreed upon. Thanks for clarifying (I can see what you mean now from the test cases; it's just a good idea to be clear about it when writing here, too). @bors r+ rollup |
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#111936 (Include test suite metadata in the build metrics) - rust-lang#111952 (Remove DesugaringKind::Replace.) - rust-lang#111966 (Add #[inline] to array TryFrom impls) - rust-lang#111983 (Perform MIR type ops locally in new solver) - rust-lang#111997 (Fix re-export of doc hidden macro not showing up) - rust-lang#112014 (rustdoc: get unnormalized link destination for suggestions) r? `@ghost` `@rustbot` modify labels: rollup
Absolutely! You did well to ask to clarify things. :) |
…ddle Add chapter in rustdoc book for re-exports and add a regression test for `#[doc(hidden)]` behaviour Fixes rust-lang#109449. Fixes rust-lang#53417. After the discussion in rust-lang#109697, I made a few PRs to fix a few corner cases: * rust-lang#112178 * rust-lang#112108 * rust-lang#111997 With this I think I covered all cases. Only thing missing at this point was a chapter covering re-exports in the rustdoc book. r? `@notriddle`
It's part of the follow-up of #109697.
Re-exports of doc hidden macros should be visible. It was the only kind of re-export of doc hidden item that didn't show up.
r? @notriddle