Skip to content

Add missing feature gate for sanitizer CFI cfgs #119235

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Dec 22, 2023

Found during the review of #118494 in #118494 (comment).

cc @rcvalle

@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 22, 2023
@rust-log-analyzer

This comment has been minimized.

@Urgau Urgau force-pushed the missing-feature-gate-sanitizer-cfi-cfgs branch from 6a0a0c2 to 157c6c1 Compare December 23, 2023 00:00
@Urgau Urgau force-pushed the missing-feature-gate-sanitizer-cfi-cfgs branch from 157c6c1 to c88b021 Compare December 23, 2023 00:01
@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 26, 2023

📌 Commit c88b021 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 26, 2023
…mpiler-errors

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119235 (Add missing feature gate for sanitizer CFI cfgs)
 - rust-lang#119240 (Make some non-diagnostic-affecting `QPath::LangItem` into regular `QPath`s)
 - rust-lang#119297 (Pass DeadItem and lint as consistent group in dead-code.)
 - rust-lang#119307 (Clean up some lifetimes in `rustc_pattern_analysis`)
 - rust-lang#119323 (add test for coercing never to infinite type)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 50e380c into rust-lang:master Dec 26, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 26, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 26, 2023
Rollup merge of rust-lang#119235 - Urgau:missing-feature-gate-sanitizer-cfi-cfgs, r=Nilstrieb

Add missing feature gate for sanitizer CFI cfgs

Found during the review of rust-lang#118494 in rust-lang#118494 (comment).

cc `@rcvalle`
@Urgau Urgau deleted the missing-feature-gate-sanitizer-cfi-cfgs branch December 27, 2023 16:55
@rcvalle rcvalle added the PG-exploit-mitigations Project group: Exploit mitigations label Dec 29, 2023
@rcvalle
Copy link
Member

rcvalle commented Dec 29, 2023

Thank you for your time and for working on this, @Urgau! Much appreciated.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
O-unix Operating system: Unix-like PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants