Skip to content

Make some non-diagnostic-affecting QPath::LangItem into regular QPaths #119240

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

compiler-errors
Copy link
Member

The rest of 'em affect diagnostics, so leave them alone... for now.

cc #115178

@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2023
@rust-log-analyzer

This comment has been minimized.

@petrochenkov
Copy link
Contributor

r=me with the clippy tests updated.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@compiler-errors
Copy link
Member Author

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Dec 25, 2023

📌 Commit d645fcb has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 25, 2023
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 26, 2023
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 26, 2023

📌 Commit 7e00e97 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 26, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 26, 2023
…mpiler-errors

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119235 (Add missing feature gate for sanitizer CFI cfgs)
 - rust-lang#119240 (Make some non-diagnostic-affecting `QPath::LangItem` into regular `QPath`s)
 - rust-lang#119297 (Pass DeadItem and lint as consistent group in dead-code.)
 - rust-lang#119307 (Clean up some lifetimes in `rustc_pattern_analysis`)
 - rust-lang#119323 (add test for coercing never to infinite type)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e7bd402 into rust-lang:master Dec 26, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 26, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 26, 2023
Rollup merge of rust-lang#119240 - compiler-errors:lang-item-more, r=petrochenkov

Make some non-diagnostic-affecting `QPath::LangItem` into regular `QPath`s

The rest of 'em affect diagnostics, so leave them alone... for now.

cc rust-lang#115178
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 28, 2023
…petrochenkov

Make some non-diagnostic-affecting `QPath::LangItem` into regular `QPath`s

The rest of 'em affect diagnostics, so leave them alone... for now.

cc rust-lang#115178
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants