Skip to content

Pass DeadItem and lint as consistent group in dead-code. #119297

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2023
Merged

Pass DeadItem and lint as consistent group in dead-code. #119297

merged 1 commit into from
Dec 26, 2023

Conversation

cjgillot
Copy link
Contributor

Fixes #119267

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 25, 2023
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 25, 2023

📌 Commit 8bb74c0 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2023
@bors
Copy link
Collaborator

bors commented Dec 25, 2023

⌛ Testing commit 8bb74c0 with merge 59859b9...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 25, 2023
@bors
Auto merge of rust-lang#119297 - cjgillot:issue-119267, r=petrochenkov
59859b9 
Pass DeadItem and lint as consistent group in dead-code.

Fixes rust-lang#119267
@bors
Copy link
Collaborator

bors commented Dec 26, 2023

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 26, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@petrochenkov
Copy link
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2023
@compiler-errors compiler-errors mentioned this pull request Dec 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 26, 2023
@bors
Auto merge of rust-lang#119324 - compiler-errors:rollup-c6eqcg9, r=co…
deace71 
…mpiler-errors

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119235 (Add missing feature gate for sanitizer CFI cfgs)
 - rust-lang#119240 (Make some non-diagnostic-affecting `QPath::LangItem` into regular `QPath`s)
 - rust-lang#119297 (Pass DeadItem and lint as consistent group in dead-code.)
 - rust-lang#119307 (Clean up some lifetimes in `rustc_pattern_analysis`)
 - rust-lang#119323 (add test for coercing never to infinite type)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 65aaece into rust-lang:master Dec 26, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 26, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 26, 2023
@rust-timer
Unrolled build for rust-lang#119297
297542b 
Rollup merge of rust-lang#119297 - cjgillot:issue-119267, r=petrochenkov

Pass DeadItem and lint as consistent group in dead-code.

Fixes rust-lang#119267
@cjgillot cjgillot deleted the issue-119267 branch December 26, 2023 22:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

ICE: assertion failed: dead_codes.iter().skip(1).all(|id|....
5 participants
@cjgillot @rustbot @petrochenkov @bors @rust-log-analyzer