Improve error messages for generics with default parameters #121416

veera-sivarajan · 2024-02-21T22:24:40Z

Fixes #120785

Issue: Previously, all type parameters with default types were deliberately ignored to simplify error messages. For example, an error message for Box type would display Box<T> instead of Box<T, _>. But, this resulted in unclear error message when a concrete type was used instead of the default type.

Fix: This PR fixes it by checking if a concrete type is specified after a default type to display the entire type name or the simplified type name.

rustbot · 2024-02-21T22:24:48Z

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_middle/src/ty/generics.rs

nnethercote · 2024-02-21T23:41:11Z

p.s. a tip for next time: for error message improvements, it makes life easier for the reviewer if you add the new test in a first commit, and then make the change to the error message in the second commit. Then the change in error output is part of the second commit :)

tests/ui/type/clarify-error-for-generics-with-default-issue-120785.rs

nnethercote · 2024-02-21T23:44:20Z

Generally looking good, just the minor comments to address above.

nnethercote · 2024-02-23T21:51:37Z

Thank you.

@bors r+

bors · 2024-02-23T21:51:39Z

📌 Commit 3927057 has been approved by nnethercote

It is now in the queue for this repository.

…thercote Improve error messages for generics with default parameters Fixes rust-lang#120785 Issue: Previously, all type parameters with default types were deliberately ignored to simplify error messages. For example, an error message for Box type would display `Box<T>` instead of `Box<T, _>`. But, this resulted in unclear error message when a concrete type was used instead of the default type. Fix: This PR fixes it by checking if a concrete type is specified after a default type to display the entire type name or the simplified type name.

bors · 2024-02-23T22:54:29Z

⌛ Testing commit 3927057 with merge 9203e70...

bors · 2024-02-23T22:57:15Z

💔 Test failed - checks-actions

albertlarsan68 · 2024-02-27T21:59:31Z

@bors retry spurious failure

…nethercote Improve error messages for generics with default parameters Fixes rust-lang#120785 Issue: Previously, all type parameters with default types were deliberately ignored to simplify error messages. For example, an error message for Box type would display `Box<T>` instead of `Box<T, _>`. But, this resulted in unclear error message when a concrete type was used instead of the default type. Fix: This PR fixes it by checking if a concrete type is specified after a default type to display the entire type name or the simplified type name.

bors · 2024-02-28T23:53:58Z

☔ The latest upstream changes (presumably #121489) made this pull request unmergeable. Please resolve the merge conflicts.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#110543 (Make `ReentrantLock` public) - rust-lang#121689 ([rustdoc] Prevent inclusion of whitespace character after macro_rules ident) - rust-lang#121724 (Use `LitKind::Err` for malformed floats) - rust-lang#121735 (pattern analysis: Don't panic when encountering unexpected constructor) - rust-lang#121743 (Opportunistically resolve regions when processing region outlives obligations) Failed merges: - rust-lang#121326 (Detect empty leading where clauses on type aliases) - rust-lang#121416 (Improve error messages for generics with default parameters) - rust-lang#121669 (Count stashed errors again) - rust-lang#121723 (Two diagnostic things) r? `@ghost` `@rustbot` modify labels: rollup

veera-sivarajan · 2024-02-29T15:11:00Z

@rustbot ready

nnethercote · 2024-02-29T21:15:34Z

@bors r+

bors · 2024-02-29T21:15:37Z

📌 Commit cc13f82 has been approved by nnethercote

It is now in the queue for this repository.

…nethercote Improve error messages for generics with default parameters Fixes rust-lang#120785 Issue: Previously, all type parameters with default types were deliberately ignored to simplify error messages. For example, an error message for Box type would display `Box<T>` instead of `Box<T, _>`. But, this resulted in unclear error message when a concrete type was used instead of the default type. Fix: This PR fixes it by checking if a concrete type is specified after a default type to display the entire type name or the simplified type name.

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#117156 (Convert `Unix{Datagram,Stream}::{set_}passcred()` to per-OS traits) - rust-lang#119199 (Add arm64ec-pc-windows-msvc target) - rust-lang#120468 (Add a new `wasm32-wasip1` target to rustc) - rust-lang#120504 (Vec::try_with_capacity) - rust-lang#121416 (Improve error messages for generics with default parameters) - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions) - rust-lang#121736 (Remove `Mutex::unlock` Function) - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block) - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`) r? `@ghost` `@rustbot` modify labels: rollup

…nethercote Improve error messages for generics with default parameters Fixes rust-lang#120785 Issue: Previously, all type parameters with default types were deliberately ignored to simplify error messages. For example, an error message for Box type would display `Box<T>` instead of `Box<T, _>`. But, this resulted in unclear error message when a concrete type was used instead of the default type. Fix: This PR fixes it by checking if a concrete type is specified after a default type to display the entire type name or the simplified type name.

…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#117156 (Convert `Unix{Datagram,Stream}::{set_}passcred()` to per-OS traits) - rust-lang#119199 (Add arm64ec-pc-windows-msvc target) - rust-lang#120468 (Add a new `wasm32-wasip1` target to rustc) - rust-lang#121416 (Improve error messages for generics with default parameters) - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions) - rust-lang#121736 (Remove `Mutex::unlock` Function) - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block) - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`) r? `@ghost` `@rustbot` modify labels: rollup

…nethercote Improve error messages for generics with default parameters Fixes rust-lang#120785 Issue: Previously, all type parameters with default types were deliberately ignored to simplify error messages. For example, an error message for Box type would display `Box<T>` instead of `Box<T, _>`. But, this resulted in unclear error message when a concrete type was used instead of the default type. Fix: This PR fixes it by checking if a concrete type is specified after a default type to display the entire type name or the simplified type name.

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#119199 (Add arm64ec-pc-windows-msvc target) - rust-lang#121416 (Improve error messages for generics with default parameters) - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions) - rust-lang#121736 (Remove `Mutex::unlock` Function) - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrte check) - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block) - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`) - rust-lang#121819 (Handle stashing of delayed bugs) - rust-lang#121828 (Remove unused fluent messages) - rust-lang#121831 (Fix typo in comment) r? `@ghost` `@rustbot` modify labels: rollup

…nethercote Improve error messages for generics with default parameters Fixes rust-lang#120785 Issue: Previously, all type parameters with default types were deliberately ignored to simplify error messages. For example, an error message for Box type would display `Box<T>` instead of `Box<T, _>`. But, this resulted in unclear error message when a concrete type was used instead of the default type. Fix: This PR fixes it by checking if a concrete type is specified after a default type to display the entire type name or the simplified type name.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#119199 (Add arm64ec-pc-windows-msvc target) - rust-lang#121416 (Improve error messages for generics with default parameters) - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions) - rust-lang#121736 (Remove `Mutex::unlock` Function) - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block) - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`) - rust-lang#121819 (Handle stashing of delayed bugs) - rust-lang#121828 (Remove unused fluent messages) - rust-lang#121831 (Fix typo in comment) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#120646 (Fix incorrect suggestion for uninitialized binding in pattern) - rust-lang#121416 (Improve error messages for generics with default parameters) - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions) - rust-lang#121580 (make unused_imports less assertive in test modules) - rust-lang#121736 (Remove `Mutex::unlock` Function) - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block) - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`) - rust-lang#121819 (Handle stashing of delayed bugs) - rust-lang#121828 (Remove unused fluent messages) - rust-lang#121831 (Fix typo in comment) - rust-lang#121850 (Make `ZeroablePrimitive` trait unsafe.) - rust-lang#121853 (normalizes-to: handle negative impls) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#121416 - veera-sivarajan:bugfix-120785, r=nnethercote Improve error messages for generics with default parameters Fixes rust-lang#120785 Issue: Previously, all type parameters with default types were deliberately ignored to simplify error messages. For example, an error message for Box type would display `Box<T>` instead of `Box<T, _>`. But, this resulted in unclear error message when a concrete type was used instead of the default type. Fix: This PR fixes it by checking if a concrete type is specified after a default type to display the entire type name or the simplified type name.

rustbot assigned nnethercote Feb 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 21, 2024

This comment has been minimized.

# to view

veera-sivarajan force-pushed the bugfix-120785 branch from 541493f to ffc9e83 Compare February 21, 2024 22:52

nnethercote reviewed Feb 21, 2024

View reviewed changes

compiler/rustc_middle/src/ty/generics.rs Outdated Show resolved Hide resolved

nnethercote reviewed Feb 21, 2024

View reviewed changes

tests/ui/type/clarify-error-for-generics-with-default-issue-120785.rs Outdated Show resolved Hide resolved

This comment has been minimized.

# to view

veera-sivarajan force-pushed the bugfix-120785 branch from f20a37d to 97e00a7 Compare February 23, 2024 03:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2024

This comment has been minimized.

# to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 23, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2024

GuillaumeGomez mentioned this pull request Feb 28, 2024

Rollup of 9 pull requests #121761

Closed

matthiaskrgr mentioned this pull request Feb 28, 2024

Rollup of 5 pull requests #121770

Merged

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 28, 2024

veera-sivarajan added 2 commits February 28, 2024 19:28

Avoid code duplication

3ba50b3

Update item order in test

cc13f82

veera-sivarajan force-pushed the bugfix-120785 branch from 3927057 to cc13f82 Compare February 29, 2024 00:37

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 29, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 29, 2024

workingjubilee mentioned this pull request Mar 1, 2024

Rollup of 9 pull requests #121834

Closed

workingjubilee mentioned this pull request Mar 1, 2024

Rollup of 8 pull requests #121836

Closed

matthiaskrgr mentioned this pull request Mar 1, 2024

Rollup of 11 pull requests #121844

Closed

matthiaskrgr mentioned this pull request Mar 1, 2024

Rollup of 10 pull requests #121845

Closed

matthiaskrgr mentioned this pull request Mar 1, 2024

Rollup of 9 pull requests #121854

Closed

matthiaskrgr mentioned this pull request Mar 1, 2024

Rollup of 12 pull requests #121859

Merged

bors merged commit f23c6dd into rust-lang:master Mar 1, 2024
11 checks passed

rustbot added this to the 1.78.0 milestone Mar 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve error messages for generics with default parameters #121416

Improve error messages for generics with default parameters #121416

veera-sivarajan commented Feb 21, 2024

rustbot commented Feb 21, 2024

This comment has been minimized.

nnethercote commented Feb 21, 2024

nnethercote commented Feb 21, 2024

This comment has been minimized.

nnethercote commented Feb 23, 2024

bors commented Feb 23, 2024

bors commented Feb 23, 2024

This comment has been minimized.

bors commented Feb 23, 2024

albertlarsan68 commented Feb 27, 2024

bors commented Feb 28, 2024

veera-sivarajan commented Feb 29, 2024

nnethercote commented Feb 29, 2024

bors commented Feb 29, 2024

Improve error messages for generics with default parameters #121416

Improve error messages for generics with default parameters #121416

Conversation

veera-sivarajan commented Feb 21, 2024

rustbot commented Feb 21, 2024

This comment has been minimized.

nnethercote commented Feb 21, 2024

nnethercote commented Feb 21, 2024

This comment has been minimized.

nnethercote commented Feb 23, 2024

bors commented Feb 23, 2024

bors commented Feb 23, 2024

This comment has been minimized.

bors commented Feb 23, 2024

albertlarsan68 commented Feb 27, 2024

bors commented Feb 28, 2024

veera-sivarajan commented Feb 29, 2024

nnethercote commented Feb 29, 2024

bors commented Feb 29, 2024