pattern analysis: Don't panic when encountering unexpected constructor #121735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Hmm... Can you explain a bit more about why rust-analyzer is encountering this but rustc doesn't? My only concern is that this filtering-out may instead hide bugs in the pattern lowering by silently filtering out patterns rather than exploding like it is now. |
|
The problem is that rust-analyzer regularly runs match checking on matches that aren't type-correct. They try to avoid that but their detection has holes. I'm not too worried about hiding bugs this way, because if an unexpected constructor shows up rustc should explode in |
|
ok thanks for the info @bors r+ rollup |
|
hello bors @bors r+ rollup |
|
@bors ping 🤔 |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 28, 2024
…r=compiler-errors pattern analysis: Don't panic when encountering unexpected constructor Tiny PR to fix rust-lang/rust-analyzer#16656 r? `@compiler-errors`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#110543 (Make `ReentrantLock` public) - rust-lang#121689 ([rustdoc] Prevent inclusion of whitespace character after macro_rules ident) - rust-lang#121724 (Use `LitKind::Err` for malformed floats) - rust-lang#121735 (pattern analysis: Don't panic when encountering unexpected constructor) - rust-lang#121743 (Opportunistically resolve regions when processing region outlives obligations) Failed merges: - rust-lang#121326 (Detect empty leading where clauses on type aliases) - rust-lang#121416 (Improve error messages for generics with default parameters) - rust-lang#121669 (Count stashed errors again) - rust-lang#121723 (Two diagnostic things) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
Rollup merge of rust-lang#121735 - Nadrieril:no-panic-on-type-error, r=compiler-errors pattern analysis: Don't panic when encountering unexpected constructor Tiny PR to fix rust-lang/rust-analyzer#16656 r? ``@compiler-errors``
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny PR to fix rust-lang/rust-analyzer#16656
r? @compiler-errors