Rollup of 5 pull requests

[matthiaskrgr]

Successful merges:

• Make ReentrantLock public #110543 (Make ReentrantLock public)
• [rustdoc] Prevent inclusion of whitespace character after macro_rules ident #121689 ([rustdoc] Prevent inclusion of whitespace character after macro_rules ident)
• Use LitKind::Err for malformed floats #121724 (Use LitKind::Err for malformed floats)
• pattern analysis: Don't panic when encountering unexpected constructor #121735 (pattern analysis: Don't panic when encountering unexpected constructor)
• Opportunistically resolve regions when processing region outlives obligations #121743 (Opportunistically resolve regions when processing region outlives obligations)

Failed merges:

• Detect empty leading where clauses on type aliases #121326 (Detect empty leading where clauses on type aliases)
• Improve error messages for generics with default parameters #121416 (Improve error messages for generics with default parameters)
• Count stashed errors again #121669 (Count stashed errors again)
• Two diagnostic things #121723 (Two diagnostic things)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=9

[bors]

📌 Commit 9f9daed has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9f9daed with merge d3d145e...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d3d145e to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#110543	Make ReentrantLock public	b3bec45440e8ef75ae729f5ed5f55ccb0e4e1fd2 (link)
#121689	[rustdoc] Prevent inclusion of whitespace character after m…	2f943774cb5b5aaee1bfa26b1b9eae0871b35b73 (link)
#121724	Use LitKind::Err for malformed floats	0688e0793c7cd4be69002903ceeff23bd7a1351f (link)
#121735	pattern analysis: Don't panic when encountering unexpected …	abf3553bd906b7c145633c4019df8e81699ce2a7 (link)
#121743	Opportunistically resolve regions when processing region ou…	92485007ca5df168757e52c5b129cdb3413b6be2 (link)

previous master: c475e2303b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (d3d145e): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.6%, 3.2%]	2
Regressions ❌ (secondary)	2.9%	[1.9%, 4.4%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.9%	[2.6%, 3.2%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-6.3%, -1.4%]	13
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 652.986s -> 650.923s (-0.32%)
Artifact size: 311.09 MiB -> 311.19 MiB (0.03%)