std: make `cmath` functions safe #139107

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merged

bors merged 1 commit into rust-lang:master from joboet:safe_cmath

Apr 13, 2025

Member

joboet commented Mar 29, 2025

The floating point intrinsics are more difficult, I'll probably wait until #119899 has merged before making them safe as well.


          std: make cmath functions safe

3a4dd1b

rustbot assigned ibraheemdev

Collaborator

rustbot commented Mar 29, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review T-libs labels

Member

ibraheemdev commented Apr 11, 2025

@bors r+ rollup

Collaborator

bors commented Apr 11, 2025

📌 Commit 3a4dd1b has been approved by ibraheemdev

It is now in the queue for this repository.

bors added S-waiting-on-bors and removed S-waiting-on-review labels

jieyouxu added a commit to jieyouxu/rust that referenced this pull request


          Rollup merge of rust-lang#139107 - joboet:safe_cmath, r=ibraheemdev

d92ce92

std: make `cmath` functions safe

The floating point intrinsics are more difficult, I'll probably wait until rust-lang#119899 has merged before making them safe as well.

jieyouxu mentioned this pull request

Rollup of 5 pull requests #139694

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#139694 - jieyouxu:rollup-7e41wed, r=jieyouxu

75a1ffa

Rollup of 5 pull requests

Successful merges:

 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139618 (compiletest: Make `SUGGESTION` annotations viral)
 - rust-lang#139677 (Fix profiler_builtins build script to handle full path to profiler lib)
 - rust-lang#139683 (Use `with_native_path` for Windows)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)

r? `@ghost`
`@rustbot` modify labels: rollup

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request


          Rollup merge of rust-lang#139107 - joboet:safe_cmath, r=ibraheemdev

11c5fd0

std: make `cmath` functions safe

The floating point intrinsics are more difficult, I'll probably wait until rust-lang#119899 has merged before making them safe as well.

ChrisDenton mentioned this pull request

Rollup of 9 pull requests #139717

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#139717 - ChrisDenton:rollup-2233f1d, r=ChrisD…

a4ce91c

…enton

Rollup of 9 pull requests

Successful merges:

 - rust-lang#137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again)
 - rust-lang#138881 (Use the chaining methods on PartialOrd for slices too)
 - rust-lang#138972 (std: Fix build for NuttX targets)
 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139607 (Add regression test for rust-lang#127424)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)
 - rust-lang#139707 (Fix comment in bootstrap)
 - rust-lang#139708 (Fix name of field in doc comment)
 - rust-lang#139709 (bootstrap: fix typo in doc string)

r? `@ghost`
`@rustbot` modify labels: rollup

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request


          Rollup merge of rust-lang#139107 - joboet:safe_cmath, r=ibraheemdev

c624457

std: make `cmath` functions safe

The floating point intrinsics are more difficult, I'll probably wait until rust-lang#119899 has merged before making them safe as well.

ChrisDenton mentioned this pull request

Rollup of 8 pull requests #139723

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#139723 - ChrisDenton:rollup-3kn4e01, r=ChrisD…

511ba12

…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138881 (Use the chaining methods on PartialOrd for slices too)
 - rust-lang#138972 (std: Fix build for NuttX targets)
 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139607 (Add regression test for rust-lang#127424)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)
 - rust-lang#139707 (Fix comment in bootstrap)
 - rust-lang#139708 (Fix name of field in doc comment)
 - rust-lang#139709 (bootstrap: fix typo in doc string)

r? `@ghost`
`@rustbot` modify labels: rollup

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request


          Rollup merge of rust-lang#139107 - joboet:safe_cmath, r=ibraheemdev

ac29f82

std: make `cmath` functions safe

The floating point intrinsics are more difficult, I'll probably wait until rust-lang#119899 has merged before making them safe as well.

ChrisDenton mentioned this pull request

Rollup of 7 pull requests #139728

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#139728 - ChrisDenton:rollup-x1xvgdd, r=ChrisD…

aded9d7

…enton

Rollup of 7 pull requests

Successful merges:

 - rust-lang#138972 (std: Fix build for NuttX targets)
 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139607 (Add regression test for rust-lang#127424)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)
 - rust-lang#139707 (Fix comment in bootstrap)
 - rust-lang#139708 (Fix name of field in doc comment)
 - rust-lang#139709 (bootstrap: fix typo in doc string)

r? `@ghost`
`@rustbot` modify labels: rollup

ChrisDenton mentioned this pull request

Rollup of 6 pull requests #139734

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#139734 - ChrisDenton:rollup-28qn740, r=ChrisD…

65fa0ab

…enton

Rollup of 6 pull requests

Successful merges:

 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139607 (Add regression test for rust-lang#127424)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)
 - rust-lang#139707 (Fix comment in bootstrap)
 - rust-lang#139708 (Fix name of field in doc comment)
 - rust-lang#139709 (bootstrap: fix typo in doc string)

r? `@ghost`
`@rustbot` modify labels: rollup

bors merged commit 5b2fd54 into rust-lang:master

6 checks passed

rustbot added this to the 1.88.0 milestone

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request


          Unrolled build for rust-lang#139107

67ab453

Rollup merge of rust-lang#139107 - joboet:safe_cmath, r=ibraheemdev

std: make `cmath` functions safe

The floating point intrinsics are more difficult, I'll probably wait until rust-lang#119899 has merged before making them safe as well.

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request


          Rollup merge of rust-lang#139107 - joboet:safe_cmath, r=ibraheemdev

5c9d14a

std: make `cmath` functions safe

The floating point intrinsics are more difficult, I'll probably wait until rust-lang#119899 has merged before making them safe as well.

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request


          Auto merge of rust-lang#139734 - ChrisDenton:rollup-28qn740, r=ChrisD…

3df6b18

…enton

Rollup of 6 pull requests

Successful merges:

 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139607 (Add regression test for rust-lang#127424)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)
 - rust-lang#139707 (Fix comment in bootstrap)
 - rust-lang#139708 (Fix name of field in doc comment)
 - rust-lang#139709 (bootstrap: fix typo in doc string)

r? `@ghost`
`@rustbot` modify labels: rollup

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

S-waiting-on-bors T-libs