Rollup of 9 pull requests #139717

ChrisDenton · 2025-04-12T17:55:47Z

Successful merges:

libstd: init(): dup() subsequent /dev/nulls instead of opening them again #137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again)
Use the chaining methods on PartialOrd for slices too #138881 (Use the chaining methods on PartialOrd for slices too)
std: Fix build for NuttX targets #138972 (std: Fix build for NuttX targets)
std: make cmath functions safe #139107 (std: make cmath functions safe)
Add regression test for #127424 #139607 (Add regression test for ICE: assertion failed: matches!(owner, hir::MaybeOwner::Phantom) #127424)
Document that opt-dist requires metrics to be enabled #139691 (Document that opt-dist requires metrics to be enabled)
Fix comment in bootstrap #139707 (Fix comment in bootstrap)
Fix name of field in doc comment #139708 (Fix name of field in doc comment)
bootstrap: fix typo in doc string #139709 (bootstrap: fix typo in doc string)

r? @ghost
@rustbot modify labels: rollup

…gain This will be faster, and also it deduplicates the code so win/win The dup() is actually infallible here. But whatever. Before: poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 1 ([{fd=2, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 2 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7f5749313050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 2 ([{fd=0, revents=POLLNVAL}, {fd=2, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 0 openat(AT_FDCWD, "/dev/null", O_RDWR) = 2 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7efe12006050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 3 ([{fd=0, revents=POLLNVAL}, {fd=1, revents=POLLNVAL}, {fd=2, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 0 openat(AT_FDCWD, "/dev/null", O_RDWR) = 1 openat(AT_FDCWD, "/dev/null", O_RDWR) = 2 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7fc2dc7ca050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 After: poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 1 ([{fd=1, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 1 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7f488a3fb050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 2 ([{fd=1, revents=POLLNVAL}, {fd=2, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 1 dup(1) = 2 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7f1a8943c050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 3 ([{fd=0, revents=POLLNVAL}, {fd=1, revents=POLLNVAL}, {fd=2, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 0 dup(0) = 1 dup(0) = 2 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7f4e3a4c7050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0

Fix std build for all NuttX targets. It is the single largest set of failures on <https://does-it-build.noratrieb.dev/>. Although, ESP-IDF also requires these same gates, there are other issues for those targets. This can verified be running `x check library/std --target=` for all NuttX targets.

libstd: init(): dup() subsequent /dev/nulls instead of opening them again This will be faster, and also it deduplicates the code so win/win The dup() is actually infallible here. But whatever. Before: ``` poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 1 ([{fd=2, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 2 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7f5749313050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 2 ([{fd=0, revents=POLLNVAL}, {fd=2, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 0 openat(AT_FDCWD, "/dev/null", O_RDWR) = 2 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7efe12006050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 3 ([{fd=0, revents=POLLNVAL}, {fd=1, revents=POLLNVAL}, {fd=2, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 0 openat(AT_FDCWD, "/dev/null", O_RDWR) = 1 openat(AT_FDCWD, "/dev/null", O_RDWR) = 2 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7fc2dc7ca050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 ``` After: ``` poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 1 ([{fd=1, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 1 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7f488a3fb050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 2 ([{fd=1, revents=POLLNVAL}, {fd=2, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 1 dup(1) = 2 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7f1a8943c050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 poll([{fd=0, events=0}, {fd=1, events=0}, {fd=2, events=0}], 3, 0) = 3 ([{fd=0, revents=POLLNVAL}, {fd=1, revents=POLLNVAL}, {fd=2, revents=POLLNVAL}]) openat(AT_FDCWD, "/dev/null", O_RDWR) = 0 dup(0) = 1 dup(0) = 2 rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[PIPE], sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x7f4e3a4c7050}, {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0 ```

…-Simulacrum Use the chaining methods on PartialOrd for slices too rust-lang#138135 added these doc-hidden trait methods to improve the tuple codegen. This PR adds more implementations and callers so that the codegen for slice (and array) comparisons also improves.

…mulacrum std: Fix build for NuttX targets Fix std build for all NuttX targets. It is the single largest set of failures on <https://does-it-build.noratrieb.dev/>. Although, ESP-IDF also requires these same gates, there are other issues for those targets. This can verified be running `x check library/std --target=` for all NuttX targets. cc `@no1wudi`

std: make `cmath` functions safe The floating point intrinsics are more difficult, I'll probably wait until rust-lang#119899 has merged before making them safe as well.

… r=petrochenkov Add regression test for rust-lang#127424 Fixes: rust-lang#127424 This ICE no longer reproduces, so it appears to have already been fixed. This PR adds a regression test to ensure the issue doesn’t come back in the future. Please let me know if there's anything I should improve or revise!

Document that `opt-dist` requires metrics to be enabled Suggested in rust-lang#139686.

Fix comment in bootstrap Didn't notice it in rust-lang#139588. r? `@jieyouxu`

…=petrochenkov Fix name of field in doc comment Trivial doc fix

bootstrap: fix typo in doc string

ChrisDenton · 2025-04-12T18:08:36Z

@bors r+ rollup=never p=5

bors · 2025-04-12T18:08:39Z

📌 Commit 7e59cc5 has been approved by ChrisDenton

It is now in the queue for this repository.

bors · 2025-04-12T20:07:19Z

⌛ Testing commit 7e59cc5 with merge a4ce91c...

…enton Rollup of 9 pull requests Successful merges: - rust-lang#137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again) - rust-lang#138881 (Use the chaining methods on PartialOrd for slices too) - rust-lang#138972 (std: Fix build for NuttX targets) - rust-lang#139107 (std: make `cmath` functions safe) - rust-lang#139607 (Add regression test for rust-lang#127424) - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled) - rust-lang#139707 (Fix comment in bootstrap) - rust-lang#139708 (Fix name of field in doc comment) - rust-lang#139709 (bootstrap: fix typo in doc string) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-04-12T20:56:21Z

The job dist-various-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] object test:false 5.659
error: unused variable: `open_devnull`
  --> library/std/src/sys/pal/unix/mod.rs:65:17
   |
65 |         let mut open_devnull = || {
   |                 ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_open_devnull`
   |
   = note: `-D unused-variables` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_variables)]`

error: variable does not need to be mutable
  --> library/std/src/sys/pal/unix/mod.rs:65:13
   |
65 |         let mut open_devnull = || {
   |             ----^^^^^^^^^^^^
   |             |
   |             help: remove this `mut`
   |
   = note: `-D unused-mut` implied by `-D warnings`

bors · 2025-04-12T20:56:58Z

💔 Test failed - checks-actions

nabijaczleweli and others added 20 commits February 23, 2025 20:22

#[allow(dead_code)]

c73cfb8

std: make cmath functions safe

3a4dd1b

codegen test for non-memcmp array comparison

19648ce

Extend the chaining logic to slices too

cf991d9

Document that opt-dist requires metrics to be enabled

394610b

Fix comment in bootstrap

ddf8237

Fix name of field in doc comment

83dd8a2

bootstrap: fix typo in doc string

32dd383

Add regression test for rust-lang#127424

11256a0

Rollup merge of rust-lang#139107 - joboet:safe_cmath, r=ibraheemdev

11c5fd0

std: make `cmath` functions safe The floating point intrinsics are more difficult, I'll probably wait until rust-lang#119899 has merged before making them safe as well.

Rollup merge of rust-lang#139691 - Kobzol:opt-dist-docs, r=jieyouxu

6c3b751

Document that `opt-dist` requires metrics to be enabled Suggested in rust-lang#139686.

Rollup merge of rust-lang#139707 - Kobzol:fix-comment, r=jieyouxu

fa113eb

Fix comment in bootstrap Didn't notice it in rust-lang#139588. r? `@jieyouxu`

Rollup merge of rust-lang#139708 - samueltardieu:push-onttwlpwurov, r…

112fc2d

…=petrochenkov Fix name of field in doc comment Trivial doc fix

Rollup merge of rust-lang#139709 - tshepang:patch-5, r=Kobzol

7e59cc5

bootstrap: fix typo in doc string

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2025

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 12, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 12, 2025

ChrisDenton mentioned this pull request Apr 12, 2025

libstd: init(): dup() subsequent /dev/nulls instead of opening them again #137494

Open

nabijaczleweli added a commit to nabijaczleweli/rust that referenced this pull request Apr 12, 2025

rust-lang#139717 (comment) 🥴

a2e3d47

nabijaczleweli added a commit to nabijaczleweli/rust that referenced this pull request Apr 12, 2025

rust-lang#139717 (comment) 🥴

ac761f2

ChrisDenton closed this Apr 13, 2025

ChrisDenton deleted the rollup-2233f1d branch April 13, 2025 01:07

thaliaarchi mentioned this pull request Apr 13, 2025

std: Fix build for NuttX targets #138972

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #139717

Rollup of 9 pull requests #139717

Uh oh!

ChrisDenton commented Apr 12, 2025

Uh oh!

ChrisDenton commented Apr 12, 2025

Uh oh!

bors commented Apr 12, 2025

Uh oh!

bors commented Apr 12, 2025

Uh oh!

rust-log-analyzer commented Apr 12, 2025

Uh oh!

bors commented Apr 12, 2025

Uh oh!

Uh oh!

Rollup of 9 pull requests #139717

Rollup of 9 pull requests #139717

Uh oh!

Conversation

ChrisDenton commented Apr 12, 2025

Uh oh!

ChrisDenton commented Apr 12, 2025

Uh oh!

bors commented Apr 12, 2025

Uh oh!

bors commented Apr 12, 2025

Uh oh!

rust-log-analyzer commented Apr 12, 2025

Uh oh!

bors commented Apr 12, 2025

Uh oh!

Uh oh!