Skip to content

Document that opt-dist requires metrics to be enabled #139691

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2025
Merged

Document that opt-dist requires metrics to be enabled #139691

merged 1 commit into from
Apr 13, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 11, 2025

Suggested in #139686.

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

@Kobzol Kobzol mentioned this pull request Apr 11, 2025
Closed
jieyouxu
jieyouxu approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 11, 2025

📌 Commit 394610b has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2025
@jieyouxu jieyouxu assigned jieyouxu and unassigned davidtwco Apr 11, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Apr 11, 2025
@jieyouxu
Rollup merge of rust-lang#139691 - Kobzol:opt-dist-docs, r=jieyouxu
ff7318e 
Document that `opt-dist` requires metrics to be enabled

Suggested in rust-lang#139686.
@jieyouxu jieyouxu mentioned this pull request Apr 11, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2025
@bors
Auto merge of rust-lang#139694 - jieyouxu:rollup-7e41wed, r=jieyouxu
75a1ffa 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139618 (compiletest: Make `SUGGESTION` annotations viral)
 - rust-lang#139677 (Fix profiler_builtins build script to handle full path to profiler lib)
 - rust-lang#139683 (Use `with_native_path` for Windows)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)

r? `@ghost`
`@rustbot` modify labels: rollup
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 12, 2025
@ChrisDenton
Rollup merge of rust-lang#139691 - Kobzol:opt-dist-docs, r=jieyouxu
6c3b751 
Document that `opt-dist` requires metrics to be enabled

Suggested in rust-lang#139686.
@ChrisDenton ChrisDenton mentioned this pull request Apr 12, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2025
@bors
Auto merge of rust-lang#139717 - ChrisDenton:rollup-2233f1d, r=ChrisD…
a4ce91c 
…enton

Rollup of 9 pull requests

Successful merges:

 - rust-lang#137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again)
 - rust-lang#138881 (Use the chaining methods on PartialOrd for slices too)
 - rust-lang#138972 (std: Fix build for NuttX targets)
 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139607 (Add regression test for rust-lang#127424)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)
 - rust-lang#139707 (Fix comment in bootstrap)
 - rust-lang#139708 (Fix name of field in doc comment)
 - rust-lang#139709 (bootstrap: fix typo in doc string)

r? `@ghost`
`@rustbot` modify labels: rollup
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 12, 2025
@ChrisDenton
Rollup merge of rust-lang#139691 - Kobzol:opt-dist-docs, r=jieyouxu
88aaf85 
Document that `opt-dist` requires metrics to be enabled

Suggested in rust-lang#139686.
@ChrisDenton ChrisDenton mentioned this pull request Apr 12, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2025
@bors
Auto merge of rust-lang#139723 - ChrisDenton:rollup-3kn4e01, r=ChrisD…
511ba12 
…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138881 (Use the chaining methods on PartialOrd for slices too)
 - rust-lang#138972 (std: Fix build for NuttX targets)
 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139607 (Add regression test for rust-lang#127424)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)
 - rust-lang#139707 (Fix comment in bootstrap)
 - rust-lang#139708 (Fix name of field in doc comment)
 - rust-lang#139709 (bootstrap: fix typo in doc string)

r? `@ghost`
`@rustbot` modify labels: rollup
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 13, 2025
@ChrisDenton
Rollup merge of rust-lang#139691 - Kobzol:opt-dist-docs, r=jieyouxu
99dad96 
Document that `opt-dist` requires metrics to be enabled

Suggested in rust-lang#139686.
@ChrisDenton ChrisDenton mentioned this pull request Apr 13, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2025
@bors
Auto merge of rust-lang#139728 - ChrisDenton:rollup-x1xvgdd, r=ChrisD…
aded9d7 
…enton

Rollup of 7 pull requests

Successful merges:

 - rust-lang#138972 (std: Fix build for NuttX targets)
 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139607 (Add regression test for rust-lang#127424)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)
 - rust-lang#139707 (Fix comment in bootstrap)
 - rust-lang#139708 (Fix name of field in doc comment)
 - rust-lang#139709 (bootstrap: fix typo in doc string)

r? `@ghost`
`@rustbot` modify labels: rollup
@ChrisDenton ChrisDenton mentioned this pull request Apr 13, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2025
@bors
Auto merge of rust-lang#139734 - ChrisDenton:rollup-28qn740, r=ChrisD…
65fa0ab 
…enton

Rollup of 6 pull requests

Successful merges:

 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139607 (Add regression test for rust-lang#127424)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)
 - rust-lang#139707 (Fix comment in bootstrap)
 - rust-lang#139708 (Fix name of field in doc comment)
 - rust-lang#139709 (bootstrap: fix typo in doc string)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b0c0ff9 into rust-lang:master Apr 13, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 13, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2025
@rust-timer
Unrolled build for rust-lang#139691
39d95bf 
Rollup merge of rust-lang#139691 - Kobzol:opt-dist-docs, r=jieyouxu

Document that `opt-dist` requires metrics to be enabled

Suggested in rust-lang#139686.
@Kobzol Kobzol deleted the opt-dist-docs branch April 13, 2025 11:45
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 19, 2025
@bors
Auto merge of rust-lang#139734 - ChrisDenton:rollup-28qn740, r=ChrisD…
3df6b18 
…enton

Rollup of 6 pull requests

Successful merges:

 - rust-lang#139107 (std: make `cmath` functions safe)
 - rust-lang#139607 (Add regression test for rust-lang#127424)
 - rust-lang#139691 (Document that `opt-dist` requires metrics to be enabled)
 - rust-lang#139707 (Fix comment in bootstrap)
 - rust-lang#139708 (Fix name of field in doc comment)
 - rust-lang#139709 (bootstrap: fix typo in doc string)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kobzol @rustbot @jieyouxu @bors @davidtwco