Skip to content

Use the new method for BasicBlockData and Statement #143190

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

Use the new method for BasicBlockData and Statement #143190

merged 2 commits into from
Jun 30, 2025

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Jun 29, 2025 •
edited by rustbot
Loading

This is the NFC part of #142771. I split it to make it easier to review for #142771. Even without #142771, I think this change is worthwhile.

@dianqk
mir: Add a new method to statement
9f9cd5e 
Avoid introducing a large number of changes when adding optional initialization fields.
@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2025

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred in coverage instrumentation.

cc @Zalathar

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in coverage instrumentation.

cc @Zalathar

@rust-log-analyzer

This comment has been minimized.

# to view
oli-obk
oli-obk approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll probably want to make those fields private in a follow-up to ensure that the constructor functions keep being used (or mark the structs #[non_exhaustive] to forbid creating them with the constructor syntax

@oli-obk
Copy link
Contributor

oli-obk commented Jun 30, 2025

r? @oli-obk

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 30, 2025

📌 Commit 24e553e has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jun 30, 2025

@bors rollup

@dianqk dianqk mentioned this pull request Jun 30, 2025
Merged
bors added a commit that referenced this pull request Jun 30, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
c65dcca 
Rollup of 14 pull requests

Successful merges:

 - #142429 (`tests/ui`: A New Order [13/N])
 - #142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - #143066 (Use let chains in the new solver)
 - #143090 (Workaround for memory unsafety in third party DLLs)
 - #143118 (`tests/ui`: A New Order [15/N])
 - #143159 (Do not freshen `ReError`)
 - #143168 (`tests/ui`: A New Order [16/N])
 - #143176 (fix typos and improve clarity in documentation)
 - #143187 (Add my work email to mailmap)
 - #143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - #143195 (`tests/ui`: A New Order [17/N])
 - #143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - #143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ab633af into rust-lang:master Jun 30, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 30, 2025
rust-timer added a commit that referenced this pull request Jun 30, 2025
@rust-timer
Unrolled build for #143190
f3b7c5a 
Rollup merge of #143190 - dianqk:new-method, r=oli-obk

Use the `new` method for `BasicBlockData` and `Statement`

This is the NFC part of #142771. I split it to make it easier to review for #142771. Even without #142771, I think this change is worthwhile.
@dianqk dianqk deleted the new-method branch June 30, 2025 22:49
@dianqk
Copy link
Member Author

dianqk commented Jun 30, 2025

you'll probably want to make those fields private in a follow-up to ensure that the constructor functions keep being used (or mark the structs #[non_exhaustive] to forbid creating them with the constructor syntax

The follow-up PR: #143262.
I probably only make statements as private since I want to add the retain_statements method.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 1, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
d02672d 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang/rust#143066 (Use let chains in the new solver)
 - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang/rust#143159 (Do not freshen `ReError`)
 - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang/rust#143176 (fix typos and improve clarity in documentation)
 - rust-lang/rust#143187 (Add my work email to mailmap)
 - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/stdarch that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
51f0bad 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang/rust#143066 (Use let chains in the new solver)
 - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang/rust#143159 (Do not freshen `ReError`)
 - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang/rust#143176 (fix typos and improve clarity in documentation)
 - rust-lang/rust#143187 (Add my work email to mailmap)
 - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 3, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
9b379be 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang/rust#143066 (Use let chains in the new solver)
 - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang/rust#143159 (Do not freshen `ReError`)
 - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang/rust#143176 (fix typos and improve clarity in documentation)
 - rust-lang/rust#143187 (Add my work email to mailmap)
 - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 4, 2025
@bors
Auto merge of rust-lang#143233 - dianqk:rollup-lcx3278, r=dianqk
3aefdd2 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang#143066 (Use let chains in the new solver)
 - rust-lang#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang#143159 (Do not freshen `ReError`)
 - rust-lang#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang#143176 (fix typos and improve clarity in documentation)
 - rust-lang#143187 (Add my work email to mailmap)
 - rust-lang#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dianqk @rustbot @rust-log-analyzer @oli-obk @bors @petrochenkov