Skip to content

Port #[link_section] to the new attribute parsing infrastructure #143196

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Port #[link_section] to the new attribute parsing infrastructure #143196

merged 1 commit into from
Jun 30, 2025

Conversation

Periodic1911
Copy link
Contributor

Ports link_section to the new attribute parsing infrastructure for #131229 (comment)

r? @oli-obk

cc @JonathanBrouwer @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

  • It's intentional.
  • The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

JonathanBrouwer
JonathanBrouwer reviewed Jun 29, 2025
View reviewed changes
obi1kenobi
obi1kenobi reviewed Jun 29, 2025
View reviewed changes
Copy link
Member

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rustdoc JSON tests and for saving the pretty-print of the attribute!

rustdoc changes LGTM.

@oli-obk
Copy link
Contributor

oli-obk commented Jun 30, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 30, 2025

📌 Commit 54cec0c has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2025
@dianqk dianqk mentioned this pull request Jun 30, 2025
Merged
bors added a commit that referenced this pull request Jun 30, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
c65dcca 
Rollup of 14 pull requests

Successful merges:

 - #142429 (`tests/ui`: A New Order [13/N])
 - #142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - #143066 (Use let chains in the new solver)
 - #143090 (Workaround for memory unsafety in third party DLLs)
 - #143118 (`tests/ui`: A New Order [15/N])
 - #143159 (Do not freshen `ReError`)
 - #143168 (`tests/ui`: A New Order [16/N])
 - #143176 (fix typos and improve clarity in documentation)
 - #143187 (Add my work email to mailmap)
 - #143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - #143195 (`tests/ui`: A New Order [17/N])
 - #143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - #143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7760cd6 into rust-lang:master Jun 30, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 30, 2025
rust-timer added a commit that referenced this pull request Jun 30, 2025
@rust-timer
Unrolled build for #143196
737774e 
Rollup merge of #143196 - Periodic1911:link_section, r=oli-obk

Port #[link_section] to the new attribute parsing infrastructure

Ports link_section to the new attribute parsing infrastructure for #131229 (comment)

r? `@oli-obk`

cc `@JonathanBrouwer` `@jdonszelmann`
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 1, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
d02672d 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang/rust#143066 (Use let chains in the new solver)
 - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang/rust#143159 (Do not freshen `ReError`)
 - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang/rust#143176 (fix typos and improve clarity in documentation)
 - rust-lang/rust#143187 (Add my work email to mailmap)
 - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/stdarch that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
51f0bad 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang/rust#143066 (Use let chains in the new solver)
 - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang/rust#143159 (Do not freshen `ReError`)
 - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang/rust#143176 (fix typos and improve clarity in documentation)
 - rust-lang/rust#143187 (Add my work email to mailmap)
 - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 3, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
9b379be 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang/rust#143066 (Use let chains in the new solver)
 - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang/rust#143159 (Do not freshen `ReError`)
 - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang/rust#143176 (fix typos and improve clarity in documentation)
 - rust-lang/rust#143187 (Add my work email to mailmap)
 - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 4, 2025
@bors
Auto merge of rust-lang#143233 - dianqk:rollup-lcx3278, r=dianqk
3aefdd2 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang#143066 (Use let chains in the new solver)
 - rust-lang#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang#143159 (Do not freshen `ReError`)
 - rust-lang#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang#143176 (fix typos and improve clarity in documentation)
 - rust-lang#143187 (Add my work email to mailmap)
 - rust-lang#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
@jdonszelmann jdonszelmann mentioned this pull request Jul 13, 2025
Open
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi left review comments

@JonathanBrouwer JonathanBrouwer JonathanBrouwer left review comments

Assignees

@oli-obk oli-obk

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Periodic1911 @rustbot @oli-obk @bors @obi1kenobi @JonathanBrouwer