Correct unused parameter diagnostic #60052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r=me once travis passes |
varkor
force-pushed
the
unused-parameter-diagnostic
branch
from
842f1f4 to
048ba28
Compare
|
@bors r=estebank rollup |
|
📌 Commit 048ba28 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 19, 2019
… r=estebank Correct unused parameter diagnostic The message was incorrect for unused lifetime parameters. There's no need to be specific.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 19, 2019
… r=estebank Correct unused parameter diagnostic The message was incorrect for unused lifetime parameters. There's no need to be specific.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 19, 2019
… r=estebank Correct unused parameter diagnostic The message was incorrect for unused lifetime parameters. There's no need to be specific.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 19, 2019
… r=estebank Correct unused parameter diagnostic The message was incorrect for unused lifetime parameters. There's no need to be specific.
bors
added a commit
that referenced
this pull request
Apr 19, 2019
Rollup of 16 pull requests Successful merges: - #59915 (Implement event filtering for self-profiler.) - #59933 (Make clear that format padding doesn't work for Debug) - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate) - #60032 (Remove unwanted z-index change) - #60041 (Simplify the returning of a Result a bit) - #60045 (Suggest appropriate path when calling associated item on bare types) - #60052 (Correct unused parameter diagnostic) - #60056 (Update rustfmt to 1.2.1) - #60060 (whitelist RTM x86 target cpu feature) - #60061 (Change suggestion of field when not in self context) - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code) - #60078 (Use more realistic example for thread builder) - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.) - #60082 (Update miri) - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8) - #60098 (libcore: deny `elided_lifetimes_in_paths`) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message was incorrect for unused lifetime parameters. There's no need to be specific.