Skip to content

Use -mergefunc-use-aliases for any LLVM >= 8 #60097

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Apr 18, 2019

This functionality is not specific to Rust's LLVM, but any starting in LLVM 8.0,
as noted in #56358 (comment).

cc @nikic
r? @rkruppe

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2019
@hanna-kruppe
Copy link
Contributor

LGTM, but I believe this is (still) the only use of LLVMRustIsRustLLVM, so could you remove it again?

@cuviper
Copy link
Member Author

cuviper commented Apr 18, 2019

Sure, now it's gone.

@hanna-kruppe
Copy link
Contributor

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 18, 2019

📌 Commit a1099ae has been approved by rkruppe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
…, r=rkruppe

Use -mergefunc-use-aliases for any LLVM >= 8

This functionality is not specific to Rust's LLVM, but any starting in LLVM 8.0,
as noted in <rust-lang#56358 (comment)>.

cc @nikic
r? @rkruppe
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
…, r=rkruppe

Use -mergefunc-use-aliases for any LLVM >= 8

This functionality is not specific to Rust's LLVM, but any starting in LLVM 8.0,
as noted in <rust-lang#56358 (comment)>.

cc @nikic
r? @rkruppe
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
…, r=rkruppe

Use -mergefunc-use-aliases for any LLVM >= 8

This functionality is not specific to Rust's LLVM, but any starting in LLVM 8.0,
as noted in <rust-lang#56358 (comment)>.

cc @nikic
r? @rkruppe
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
…, r=rkruppe

Use -mergefunc-use-aliases for any LLVM >= 8

This functionality is not specific to Rust's LLVM, but any starting in LLVM 8.0,
as noted in <rust-lang#56358 (comment)>.

cc @nikic
r? @rkruppe
bors added a commit that referenced this pull request Apr 19, 2019
Rollup of 16 pull requests

Successful merges:

 - #59915 (Implement event filtering for self-profiler.)
 - #59933 (Make clear that format padding doesn't work for Debug)
 - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate)
 - #60032 (Remove unwanted z-index change)
 - #60041 (Simplify the returning of a Result a bit)
 - #60045 (Suggest appropriate path when calling associated item on bare types)
 - #60052 (Correct unused parameter diagnostic)
 - #60056 (Update rustfmt to 1.2.1)
 - #60060 (whitelist RTM x86 target cpu feature)
 - #60061 (Change suggestion of field when not in self context)
 - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code)
 - #60078 (Use more realistic example for thread builder)
 - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.)
 - #60082 (Update miri)
 - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8)
 - #60098 (libcore: deny `elided_lifetimes_in_paths`)

Failed merges:

r? @ghost
@bors bors merged commit a1099ae into rust-lang:master Apr 19, 2019
@cuviper cuviper deleted the llvm8-mergefunc-use-aliases branch May 17, 2019 21:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants