Skip to content

Stabilize Stdin::lines. #95185

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2022
Merged

Stabilize Stdin::lines. #95185

merged 2 commits into from
Apr 7, 2022

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Mar 21, 2022

Closes #87096

Fcp completed here: #87096 (comment)

@m-ou-se m-ou-se added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 21, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2022
@m-ou-se m-ou-se mentioned this pull request Mar 21, 2022
Closed
4 tasks
@m-ou-se m-ou-se added this to the 1.61.0 milestone Apr 1, 2022
@Mark-Simulacrum
Copy link
Member

r=me with 1.62 bump, since we're already branched for 1.61. Apologies for the review delay.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2022
m-ou-se
m-ou-se commented Apr 6, 2022
View reviewed changes
@m-ou-se
Copy link
Member Author

m-ou-se commented Apr 6, 2022

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Collaborator

bors commented Apr 6, 2022

📌 Commit f87d180 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 6, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 6, 2022
@Dylan-DPC
Rollup merge of rust-lang#95185 - m-ou-se:stabilize-stdin-lines, r=Ma…
b430f62 
…rk-Simulacrum

Stabilize Stdin::lines.

Closes rust-lang#87096

Fcp completed here: rust-lang#87096 (comment)
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 6, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2022
@bors
Auto merge of rust-lang#95745 - Dylan-DPC:rollup-485ajqi, r=Dylan-DPC
2310da4 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95185 (Stabilize Stdin::lines.)
 - rust-lang#95626 (Don't cast thread name to an integer for prctl)
 - rust-lang#95709 (Improve terse test output.)
 - rust-lang#95735 (Revert "Mark Location::caller() as #[inline]")
 - rust-lang#95738 (Switch item-info from div to span)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d2f1a0b into rust-lang:master Apr 7, 2022
@rustbot rustbot modified the milestones: 1.61.0, 1.62.0 Apr 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for Stdin::lines forwarder method
5 participants
@m-ou-se @rust-highfive @Mark-Simulacrum @bors @rustbot