Skip to content

Revert "Mark Location::caller() as #[inline]" #95735

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2022
Merged

Revert "Mark Location::caller() as #[inline]" #95735

merged 1 commit into from
Apr 7, 2022

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Apr 6, 2022

This reverts #95619. As noted in #95619 (comment) this seems to break several tests with cg_clif.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2022
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 6, 2022

📌 Commit 6a7ff98 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2022
@bors
Auto merge of rust-lang#95745 - Dylan-DPC:rollup-485ajqi, r=Dylan-DPC
2310da4 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95185 (Stabilize Stdin::lines.)
 - rust-lang#95626 (Don't cast thread name to an integer for prctl)
 - rust-lang#95709 (Improve terse test output.)
 - rust-lang#95735 (Revert "Mark Location::caller() as #[inline]")
 - rust-lang#95738 (Switch item-info from div to span)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b22df08 into rust-lang:master Apr 7, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 7, 2022
@the8472 the8472 mentioned this pull request Apr 23, 2022
Merged
@bjorn3 bjorn3 deleted the revert_inline_location_caller branch May 11, 2022 10:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@bjorn3 @rust-highfive @compiler-errors @bors @Mark-Simulacrum @rustbot