Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix match highlighting on small screens #26

Merged
merged 7 commits into from
May 12, 2020
Merged

Fix match highlighting on small screens #26

merged 7 commits into from
May 12, 2020

Conversation

shreyasminocha
Copy link
Owner

@shreyasminocha shreyasminocha commented May 11, 2020 •
edited
Loading

Resolves #5

  • test cases where the entire string matches
  • test cases where part of the string matches

@vercel
Copy link

vercel bot commented May 11, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shreyasminocha/refrf/ld1q5tm25
✅ Preview: https://refrf-git-small-screens.shreyasminocha.now.sh

@shreyasminocha
Use <mark> for match highlighting
4932741 
Aligning the ordered list of matches with character units, while novel,
was too tedious to maintain. It reportedly caused issues with some
browsers and was a nightmare to get right on mobile devices.

Resolves #5
Resolves #14
@shreyasminocha shreyasminocha marked this pull request as ready for review May 12, 2020 08:51
@shreyasminocha shreyasminocha merged commit bbf01ef into master May 12, 2020
@shreyasminocha shreyasminocha deleted the small-screens branch May 12, 2020 08:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix match highlighting on small screens
1 participant
@shreyasminocha