handle whitespace for file uploads (attempt 2) #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirror behaviour noted in issue
saves a lot of encoding problems
# Conflicts: # app/assets/javascripts/file_upload.js # app/controllers/concerns/file_handling_for_datasets.rb # app/models/dataset_file.rb # spec/features/add_github_public_dataset_spec.rb
|
Hey @Floppy is this good to review & approve or is it still WIP? |
quadrophobiac
approved these changes
Aug 16, 2017
| @@ -305,7 +305,7 @@ | |||
| { | |||
| title: "New file", | |||
| description: "New file description", | |||
| file: "http://example.com/new-file.csv", | |||
There was a problem hiding this comment.
how come example.com is removed in this spec?
There was a problem hiding this comment.
Because the file key in the S3 uploader is no longer a URL, just the storage key. So I've removed the protocol and port which would have been added before.
|
Good to go. |
Floppy
changed the title
|
Sorry forgot to remove WIP tag, this is OK to merge. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427. We upload to s3 and then download, both using the s3 API not public URLs. But we were turning the storage keys into URLs for passing around, completely unnecessarily. This change makes the code just pass around storage keys, which don't need special encoding.