Revert "handle whitespace for file uploads (attempt 2)" #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quadrophobiac this has uncovered a problem internally which is requiring a major refactor to fix (see #602). Because #554 is more critical than the bug this PR fixed (#427) I'd like to back this change out until that refactor is complete. But, it's going to take a while and a client is waiting. They'll be happier with a small whitespace bug than with being unable to upload schemas at all. |
quadrophobiac
approved these changes
Sep 13, 2017
This was referenced Sep 13, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #567, because it causes other upload problems with schemas (#554). I'm not sure how long it will take me to fix 554, so until that's sorted, this had better back out.