[WIP] Fix uploading with schemas #602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this doesn't work at all with the DatasetFileSchema upload form. This is a real ballache as the S3 javascript upload doesn't seem to be tested hardly at all. sob |
Undid revert pulled in from master branch, as I still want that code on this one.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #554 and #427. Previous changes in #567 meant that the uploader wasn't working any more with the schema files. This adjusts the schema upload code to work with the new uploader which only uses storage keys, not full URLs.
It now reconstructs a URL internally so as not to affect the underlying code too much. A further refactor may follow to simplify this all away completely.