-
Notifications
You must be signed in to change notification settings - Fork 5k
Web3.js Planning Meetings 2021
Attendance
- Wyatt, Alex, Junaid, Phil, Mike
Sprint (Nov 2-16) Review
- 1.6.1 - Released
- 4.x
- WIP: web3-core, web3-utils, web3-Eth, web3-providers-ws, web3-profider-http, accounts/wallet
- Not started: eth-tx
Sprint Retro
- Went Well
- Troubleshoot & Release 1.6.1
- To Improve
- ZenHub: Update Issues, Link issues to Epic, Don't move Epics, Update Estimation
- Backlog Grooming: Decompose Epics
- Each Sprint: Clearing Review/QA column, Focus on Sprint scope/goals
Sprint Planning
- Goal
- ZenHub Improvements
- Clearing out Review/QA Column by end of sprint
- Pre-assign all sprint issues
- 1.x
- 1.7.0
- 4.x
- ABI, ETH
- ZenHub Improvements
- 1.x Issues
- 1.6.1
- Documentation update #4425
- 1.7.0
- #4436 Failing gnosis dex tests
- #4274 PR: Sorted batch requests
- #4232 PR: Updates Transaction and TransactionConfig types
- Investigate
- #4512: Incorrect value interpreted as null
- #4509: Don't autofill gasPrice on transactions
- #4500: Same Nonce issue
- 1.6.1
- 4.x rewrite
- Continue WIP:
- Web3-ABI (#4544)
- Web3-Eth (#4483)
- Web3-Eth-Transaction (Decompose and work)
- Accounts/Wallet
- Extended Objective: Decompose, add complexity estimates and start:
- Contracts
- ENS
- Continue WIP:
Additional Notes
- Priority needs to be with decomposing Epics
- Decomposing remaining Epics will allow us to build a Roadmap in ZenHub and provide better delivery estimates
Attendance
- Wyatt, Alex, Junaid, Nazar, Phil, Mike
Updates
Wyatt
- Review PR for SubscriptionManager and RequestManager (#4478)
- Merged into working web3-eth branch
Alex -Added more test cases
- Switched ethers.js for hashing encoding tests
- We now use js-sha3 for tests
- Looking into open PRs and validation functions + testing
Junaid
- Investigating why build sizes on 1.x are so large from previous. We are on the right track to find solution.
- 2 PRs waiting for approvals
Nazar
- Was able to reduce build size to 1.68mb using the exact same dependencies used on
1.5.3
.- Size problem is within
ethereumjs-tx
bug fixes which are important for EIP-1559 transactions. -
ethereumjs-common
package2.5.0
is about 3.5x larger. We could lock it to2.4.0
and it would be fine, but not recommended as described.
- Size problem is within
- Before implementing fixes on
1.6.1
, package size is about 2.4mb (almost +1mb from1.5.3
).- Fixes are just downgrading and fixing the versions
- Still investigating to see how we can utilise the latest
ethereumjs
package while maintaining a small bundle size
Phil
- CSCON[1] will include a presentation from Web3.js. Unsure at the moment what will be demoable by Dec 1, but goal is to at least present what we are working on as part of the 4.x rewrite and help users anticipate what to expect.
- Web3js.org landing page being finalized for launch. Discussions still ongoing about how everything will connect together.
- Initial plan to setup direct Web3JS Project <> Web3JS User communications. Anticipate a mailing list type newsletter for important updates focused specifically on web3.js
Additional Notes
-
Phil: Main goal for this week is to fix up our release process and build issues with 1.x releases and expand release management tasks to the rest of the team.
-
We should investigate #4500 Nonce value is same when using two instance for two chains. Need to determine priority of this issue. Reproducable repo link provided by community member.
-
Junaid: We have duplicate issues under
web3-eth
.- Wyatt will close the duplicate issues and link to the epics.
Attendance
- Wyatt, Alex, Junaid, Nazar, Phil
Updates
Wyatt
- Eth consensus JSON RPC support complete (#4374)
- Just need to write tests
- Need to coordinate and update with Junaid about JSON RPC types and other merge conflicts.
- ESLint: Config package.json was hard-coded to specific versions, not
^x.x.x
which causing mismatch of diversion installs. Fix included with http package. - Http PR ready for review, will open up new PR for missing unit tests.
Alex
- #4352: Added width for the function
- #4351: Started working on bloom filters.
Junaid
- web3-providers-ws:
- Need to add events and tests.
- Few changes in web3 base class: RequestMethod
- Tailored for 1193 and not good for websocket
- Approved #4455 and merged
Nazar
- #4447, #4451, #4459 requesting reviews.
Attendance
- Wyatt, Junaid, Nazar, Phil
Updates
Wyatt
- Epics forEIP-1193 + http-provider complete
- Bunch of PRs to look
- What can we do to rectify the process?
- Adding #4300 to 1.6.1 release
- Created new issue templates.
- Releasing
1.6.0
- Epics are blocked on web3 core and common. Awaiting finalization of those APIs.
Nazar
- Closed #4341
- Closed #3742
- Could not reproduce directly with geth client
- Issue if we use red hat or ganache. But likely issues with the providers
- Opened issue in red hat linked to this PR
- 3 PRs for review
- Web3BaseWallet #4395 and Web3BaseProvider #4361 - Please review and merge.
- List utils
- Finishing epics for web3-common.
- #3897: Will put this aside as 4.x epics take priority
Junaid
- Added findings on UnHandledPromiseRejectionWarning #4392
- Added comments to Problem sending in Type 2 Tx #4364
- Closed #4346, #4309, #4177, #4176
- Reviewed:
- #4377 web3-common errors
- #4395 for base provider and base wallet, requested changes base provider shoudnt enforce 1193,
- #4396 approved - Create web3-utils package structure
- #4365 approved - web3 report issue github template
Phil
- Updated team work processes for responsibilities expected of triaging
Community Issues Management
board. - New PM for Web3.js starting Oct 13.
Additional Notes
- Please input your thoughts on Nazar's discussion about using
Buffer
instead ofUint8Array
- Please input your thoughts on some inconsistencies among
hexToNumber
andhexToNumberString
functions.
Attendance
- Wyatt, Alex, Junaid, Nazar, Phil
Updates
Junaid
- Github Issues (Community engagement is important even if we need to put issues on hold for other priorities, we just need to communicate)
- Prioritize, try to reproduce and discuss these issues on the tickets
- Phil: Utilise the issuer to list out step by step how to reproduce issues. We do not have the capacity to re-create bugs without full context on our own and do not be afraid to press for more information.
- 3897: Lots of activity on this, opened on Feb 2. We should respond on this after investigating further. Assigned to Nazar.
- 4250: Phil responded echoing Wyatt's statement on prioritising resources elsewhere
Nazar
- Prepared presentation on 4.x architecture
- 3891: Pulling issue taking bandwith from transaction received
- Optimized it multiple approaches
- If approach decision is made, tests will be created for it
- Investigating 3742
- Digging further to pinpoint issue for solutions
- Please ask questions to Nazar about concerns relating to 4.x proposal
Alex
- 4070: Webpack 5 support
- Added required node modules into web3js
- Still getting polyfill issues
- Fix webpack 5 errors in web3js then upgrading it and trying to force AngularJS's webpack config to use a different webjs build that uses node_modules on webpack 5 changes
- 4244: Working on replicating the bug
Wyatt
- 4307: Needs re-review to update changelogs
- 3947 -> 4298: Tests are passing, reviews required.
- Don't fully understand what's happening. Nazar will check.
- 4081: Started doing research on this.
- Gaugeing complexity to see if this is something that should be prioritized
- 1.5.3-rc0 is out. No testing has been done yet with it. Wyatt will test today. Aim to release for Thursday.
- Junaid: Seconded. Let's release Thursday.
Phil
- Town Hall slides complete
- Create notifications for issue handling responsibility
- 4.x Docs will be created on Gitbook
Additional Notes
- Wyatt: 4326 issue
baseFeePerGas
RPC returns hex string instead of BN number. This is a breaking change, how do we deal with this? Berlin code has been out for a while and hex string has been the standard so far.- Junaid: Can we open a PR on this to have discussion on how to release that.
Attendance
- Junaid, Nazar, Phil
Updates
Phil
- Was working on Web3 Users feedback survey.
- Added github discussion for Survey.
- Got update of web3 grants.
Nazar
- Was doing analysis of #3891
Not getting success callback
Issue. - Will open PR for Issue #3891.
- Spent time on 4.x architecture / design choices.
- Will review PRs today.
Junaid
-
Discovered bug web3.eth.accounts.signTransaction returning invalid and was working on its PR.
-
Was working on following PR: Don't require chainId if common is present .
-
Closed Legacy gas fee estimation .
-
Reviewed Fix unsubscribe and add a test .
-
Reviewed Add clientConfig to WS test and investigated related issue .
-
Onboarding document maintenance.
-
Submitted team review for web3.js team on chainsafe latticehq.
-
Sprint Review, Retro, Planning presentation.
Additional Notes
- Discussion on 4.x vision document.
- Phil: Nazar will review survey.
- Nazar: Agreed to review / adding questions.
Attendance
- Junaid, Nazar, Wyatt
Updates
Wyatt
- Created dependency graph of packages
- Working on
- HTTP Provider refactor
- Logging modules
- having config file for defining logging level?
- Will do web3-eth-tx package after logging package work
Nazar
- Completed PR https://github.com/ChainSafe/web3.js/pull/4284
- Now tests are passing
- will start looking https://github.com/ChainSafe/web3.js/issues/4235
Junaid
-
Spent most of the time on management tasks.
-
Lattice Setup
- Wyatt, Alex, Nazar: Now its bi-weekly , earlier it was monthly.
- WIP:
- Define objectives and derive list of items from that to discuss in 1:1
- Lattice weekly survey for feedback
-
Performance Review:
- Peer reviewers selection For: Alex and Wyatt
- Setup of reminder / placeholder
- Process discussion with Phil and Marin
-
Nazar Onboarding checklist for TL
-
Web3.js Product Owner and Team lead Sync
- 4.x RoadMap and Sprints Alignment init
- Phil will create 4.x epics and will add in zenhub roadmap
- Github issues board planning: board created ,
- Phil WIP: will refine it and will connect with sprint board/workspace
- 4.x RoadMap and Sprints Alignment init
-
Reviewed Wyatt PR for 'EIP-1559 Fix Issue'
Additional Notes
-
Wyatt: Options for State management in web3.js for providers
-
Nazar: will explore option of Functional approach for 4.x
-
Junaid: We should follow separation of concern and decoupling packages for state management
-
Nazar: we should use Node.js debug instead of web3.js level logging package
All discussed moving Architecture meeting to next week.