-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
rc.board_param init file to specify custom board param save location #20805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the intent of how this is supposed to work.
So what's the intent how it's supposed to work? |
All the paths are legacy V2 or flexible with the mtd.cpp in the board fille. On can define mtd.cpp in the board support if the default v2 mtd behavior (that is FRAM only) is not enough. Then the manifest (mft) can be queried See https://github.com/PX4/PX4-Autopilot/blob/main/src/systemcmds/mft/mft.cpp The usage in RC is determining if the Keys Subject and value are present. The rest of the mounts are done by the system. The mtd command can be used to. https://github.com/PX4/PX4-Autopilot/blob/main/src/systemcmds/mtd/mtd.cpp I think your use case would be served by an mtd.cpp file and follow the naming convention for param. If not we can hop on a call and work it out. |
fc63b6b
to
bd83cc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this makes sense. Let's see if HW CI passes
@PetervdPerk-NXP please rebase! See #20794 (comment) |
bd83cc8
to
ed3e2e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - What has CI so bent out of shape?
97cc9d7
to
e1a20e3
Compare
e1a20e3
to
3d16afa
Compare
@davids5 Previous proposal broke backup/fallback mechanism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PetervdPerk-NXP - good catch and solution
After the parameter server is in place (#20773) I was thinking of pushing more of this into kconfig and getting away from the brittle init script configuration of the parameter system. Let me know if you have any input. |
Logfile of driving around indoors yesterday - https://logs.px4.io/plot_app?log=0d0ab8ed-2c00-4c19-a6d1-8931975f00ae |
@dagar but for now it seems like this would be a good change to have in (we can accommodate to parameter server later), what do you think? |
During today's maintainers call, @dagar pointed out that directory where the flight log gets saved to should rather be a parameter to the user to set. But this would be a good first step into having a more flexible data path in px4. Could we get this in since it's already approved? |
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-community-q-a-july-26-2023/33335/1 |
MTD_PARAMETERS can be freely defined as any path in the board definition.
But the rcS startup script still has to check all paths manually for all boards.
Current status:
Add board specific rc.board_param file where the board can specify the parameter save file.