Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Decouple filepaths from rcS/MTD using Kconfig #21891

Closed

Conversation

PetervdPerk-NXP
Copy link
Member

@PetervdPerk-NXP PetervdPerk-NXP commented Jul 26, 2023

As an alternative to #20805 and discussed in today's dev call.

File path configuration through Kconfig.

For now we only introduce symbols for param and logger.

  • BOARD_LOG_DIR
  • BOARD_PARAM_FILE

Furthermore we generate a ROMFS rc.filepaths that takes BOARD_PARAM_FILE

@PetervdPerk-NXP PetervdPerk-NXP requested review from dagar and davids5 July 26, 2023 16:59
@PetervdPerk-NXP PetervdPerk-NXP marked this pull request as draft July 26, 2023 17:00
@github-actions github-actions bot added the stale label Sep 1, 2023
@PetervdPerk-NXP PetervdPerk-NXP changed the title [RFC] Initial attempt to decouple filepaths from rcS/MTD using Kconfig Decouple filepaths from rcS/MTD using Kconfig Feb 5, 2024
@PetervdPerk-NXP
Copy link
Member Author

@dagar I've changed the mechanism a bit could you take a look it?

@Igor-Misic I've added a second commit here as well to use LittleFS on the fmu-v6xrt. I saw you were working on LittleFS before would you be able to test this on your hardware and share your thoughts?

@PetervdPerk-NXP
Copy link
Member Author

Moved the LittleFS commit to #22749
Overall I think it's ready for review.
Also this PR poses a potential fix for #22590 because one simply has to format the QSPI with a filesystem and then define BOARD_LOG_DIR to point to the mount point of the filesystem.

@PetervdPerk-NXP PetervdPerk-NXP force-pushed the pr-kconfig-file-path branch 2 times, most recently from f01dda4 to 32df51f Compare March 15, 2024 20:37
@davids5
Copy link
Member

davids5 commented Apr 10, 2024

@PetervdPerk-NXP I am looking at the notion of replacing the persistent storage location /fs/microsd across the system. This path is hardcoded in a lot of places, UAVCAN, NetMan, DataMan etc. The approach I was considering was to create #if !defined(PX4_ROOT_STOAGE) and set it in board_comon.h to the current default.. Then any board can override it by setting it in board_config.h. Now that you have this mechanism; What would you suggest should be done?

@PetervdPerk-NXP
Copy link
Member Author

Superseded by #23003

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants