Skip to content

Commit

Permalink
Revert "fix gn check that broke again with #25799 (#25830)"
Browse files Browse the repository at this point in the history
For some unknown reason this PR has broken the Windows debug use of
`json::convert_all_numbers_to_string` and others.

Resolves brave/brave-browser#41497

This reverts commit a235817.
  • Loading branch information
cdesouza-chromium committed Oct 8, 2024
1 parent 093e733 commit 2d107f4
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 16 deletions.
22 changes: 9 additions & 13 deletions browser/brave_adaptive_captcha/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,18 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
# You can obtain one at https://mozilla.org/MPL/2.0/.

source_set("impl") {
visibility = [ "//chrome/browser" ]
source_set("brave_adaptive_captcha") {
sources = [
"brave_adaptive_captcha_service_factory.cc",
"brave_adaptive_captcha_service_factory.h",
]

sources = [ "brave_adaptive_captcha_service_factory.cc" ]
public_deps = [
"//components/keyed_service/content",
"//content/public/browser",
]

deps = [
":brave_adaptive_captcha",
"//base",
"//brave/browser/brave_rewards",
"//brave/components/brave_adaptive_captcha",
Expand All @@ -19,12 +24,3 @@ source_set("impl") {
"//components/user_prefs",
]
}

source_set("brave_adaptive_captcha") {
sources = [ "brave_adaptive_captcha_service_factory.h" ]

public_deps = [
"//components/keyed_service/content",
"//content/public/browser",
]
}
3 changes: 1 addition & 2 deletions browser/sources.gni
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ brave_chrome_browser_deps = [
"//brave/app:brave_generated_resources_grit",
"//brave/browser:browser_process",
"//brave/browser:sparkle_buildflags",
"//brave/browser/brave_adaptive_captcha:impl",
"//brave/browser/brave_federated",
"//brave/browser/brave_rewards:brave_rewards_impl",
"//brave/browser/brave_rewards:util",
Expand All @@ -139,6 +138,7 @@ brave_chrome_browser_deps = [
"//brave/components/ai_chat/core/common/buildflags",
"//brave/components/ai_rewriter/common/buildflags",
"//brave/components/body_sniffer",
"//brave/components/brave_adaptive_captcha",
"//brave/components/brave_ads/browser",
"//brave/components/brave_ads/core",
"//brave/components/brave_component_updater/browser",
Expand Down Expand Up @@ -503,7 +503,6 @@ if (is_win && is_official_build) {
brave_chrome_browser_public_deps = [
"//brave/app/vector_icons",
"//brave/browser:browser_process",
"//brave/components/brave_adaptive_captcha",
"//brave/components/brave_sync:constants",
"//brave/components/variations",
]
Expand Down
1 change: 0 additions & 1 deletion browser/ui/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ source_set("ui") {
]

deps = [
"//brave/browser/brave_adaptive_captcha",
"//brave/browser/brave_rewards",
"//brave/browser/skus",
"//brave/components/brave_shields/core/browser",
Expand Down

0 comments on commit 2d107f4

Please # to comment.