-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Rewards 3.0] Add adaptive captcha modal #25799
Conversation
A Storybook has been deployed to preview UI for the latest push |
44af36f
to
783c735
Compare
783c735
to
e0904b1
Compare
DCHECK(!tooltip_popups_[tooltip_id]); | ||
tooltip_popups_[tooltip_id] = | ||
new brave_tooltips::BraveTooltipPopup(profile, std::move(tooltip)); | ||
if (!tooltip_popups_[tooltip_id]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept running into this DCHECK while testing. I think there's something odd in the staging environment that keeps trying to show the tooltip over and over. In any case, it seems like it's not an invariant that we can hold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e0904b1
to
59606b8
Compare
[puLL-Merge] - brave/brave-core@25799 DescriptionThis PR introduces several changes to the Brave Rewards system, primarily focusing on the implementation of an adaptive captcha feature and various UI improvements. The changes span across multiple components and files, enhancing the user experience and security of the Rewards system. ChangesChanges
Possible Issues
Security Hotspots
Overall, this PR significantly enhances the Brave Rewards system with new security features and UI improvements. The captcha implementation is a notable addition that should improve the system's resistance to automated abuse. |
Released in v1.72.63 |
For some unknown reason this PR has broken the Windows debug use of `json::convert_all_numbers_to_string` and others. Resolves brave/brave-browser#41497 This reverts commit a235817.
Resolves brave/brave-browser#41403
(This is a port of the existing adaptive captcha user interface, copied from the existing Rewards panel implementation.)
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: