Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Disabled menu bar menu can still be open using keyboard #17915

Open
Dumluregn opened this issue Feb 12, 2025 · 0 comments · May be fixed by #18057
Open

Disabled menu bar menu can still be open using keyboard #17915

Dumluregn opened this issue Feb 12, 2025 · 0 comments · May be fixed by #18057
Labels
package:ui status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Dumluregn
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Open any demo with menu bar, e.g. https://ckeditor.com/docs/ckeditor5/latest/examples/builds-custom/full-featured-editor.html
  2. Disable a menu from menu bar typing editor.ui.view.menuBarView.menus[ 0 ].isEnabled = false; in the console.
  3. Focus the editor.
  4. Press Opt+F9 to focus menu bar.
  5. Press "arrow down" when the disabled menu is focused.

✔️ Expected result

Nothing happens, menu should not be open.

❌ Actual result

Menu opens normally.

Image

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Dumluregn Dumluregn added package:ui type:bug This issue reports a buggy (incorrect) behavior. labels Feb 12, 2025
@Dumluregn Dumluregn mentioned this issue Feb 17, 2025
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Feb 17, 2025
Dumluregn added a commit that referenced this issue Mar 5, 2025
@Dumluregn
Merge pull request #17941 from ckeditor/ck/fullscreen-revision-history
4a00141 
Fix (ui): Do not open disabled menu bar menu on arrow down press. Closes #17915.

Feature (ui): Add `MenuBarView#disable()` and `MenuBarView#enable()` methods. They disable/enable all top-level menus in menu bar. Closes #17940.

Internal (fullscreen): Add integration with revision history.

Internal (ui): Add a toolbar property to the `EditorUIView` class for coherent access for all editor types.

Internal (ui): Make `EditorUI#_initMenuBar()` method public and rename it accordingly to allow for runtime toolbar creation.
@Dumluregn Dumluregn mentioned this issue Mar 5, 2025
Merged
Dumluregn added a commit that referenced this issue Mar 5, 2025
@Dumluregn
Merge pull request #17897 from ckeditor/ck/fullscreen-bootstrap
430fde4 
Fix (ui): Do not open disabled menu bar menu on arrow down press. Closes #17915.

Feature (ui): Add `MenuBarView#disable()` and `MenuBarView#enable()` methods. They disable/enable all top-level menus in menu bar. Closes #17940.

Feature (fullscreen): Introduce a fullscreen mode feature. Closes #18026.
@Dumluregn Dumluregn linked a pull request Mar 5, 2025 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
package:ui status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce a fullscreen mode feature ckeditor/ckeditor5
2 participants
@Dumluregn @CKEditorBot