-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Introduce a fullscreen mode feature #18057
Open
Dumluregn
wants to merge
77
commits into
master
Choose a base branch
from
ck/epic/1235-fullscreen-mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into epic/1235-fullscreen-mode-presence-list
… into epic/1235-fullscreen-mode-presence-list
Internal (fullscreen): Add fullscreen integration with editor created in the iframe. Internal (fullscreen): Allow to configure a custom container where fullscreen should be initialized.
Internal (fullscreen): Add integration with pagination feature.
…-mode-presence-list
…sence-list Internal: Presence list and document outline for fullscreen mode.
Internal: Add `ctrl+shift+f` keystroke for toggling fullscreen mode.
Internal (fullscreen): Add proper feature icons.
…itor5 into epic/1235-fullscreen-mode-dialogs
…logs Internal: Dialog plugin position adjustments in fullscreen mode.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (fullscreen): Introduce a fullscreen mode feature. Closes #18026.
Fix (ui): Do not open disabled menu bar menu on arrow down press. Closes #17915.
Feature (ui): Add
MenuBarView#disable()
andMenuBarView#enable()
methods. They disable/enable all top-level menus in menu bar. Closes #17940.Feature (source-editing): Hide document outline and annotations when entering source editing mode. Closes #17978.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.