Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add methods for disabling and enabling menu bar #17940

Open
Dumluregn opened this issue Feb 17, 2025 · 0 comments · May be fixed by #18057
Open

Add methods for disabling and enabling menu bar #17940

Dumluregn opened this issue Feb 17, 2025 · 0 comments · May be fixed by #18057
Assignees
@Dumluregn
Labels
package:ui status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@Dumluregn
Copy link
Contributor

📝 Provide a description of the new feature

Now you'd have to do this separately for each menu bar menu.

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@Dumluregn Dumluregn added package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels Feb 17, 2025
@Dumluregn Dumluregn self-assigned this Feb 17, 2025
@Dumluregn Dumluregn mentioned this issue Feb 17, 2025
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Feb 17, 2025
Dumluregn added a commit that referenced this issue Mar 5, 2025
@Dumluregn
Merge pull request #17941 from ckeditor/ck/fullscreen-revision-history
4a00141 
Fix (ui): Do not open disabled menu bar menu on arrow down press. Closes #17915.

Feature (ui): Add `MenuBarView#disable()` and `MenuBarView#enable()` methods. They disable/enable all top-level menus in menu bar. Closes #17940.

Internal (fullscreen): Add integration with revision history.

Internal (ui): Add a toolbar property to the `EditorUIView` class for coherent access for all editor types.

Internal (ui): Make `EditorUI#_initMenuBar()` method public and rename it accordingly to allow for runtime toolbar creation.
@Dumluregn Dumluregn mentioned this issue Mar 5, 2025
Merged
Dumluregn added a commit that referenced this issue Mar 5, 2025
@Dumluregn
Merge pull request #17897 from ckeditor/ck/fullscreen-bootstrap
430fde4 
Fix (ui): Do not open disabled menu bar menu on arrow down press. Closes #17915.

Feature (ui): Add `MenuBarView#disable()` and `MenuBarView#enable()` methods. They disable/enable all top-level menus in menu bar. Closes #17940.

Feature (fullscreen): Introduce a fullscreen mode feature. Closes #18026.
@Dumluregn Dumluregn linked a pull request Mar 5, 2025 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Dumluregn Dumluregn

Labels
package:ui status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce a fullscreen mode feature ckeditor/ckeditor5
2 participants
@Dumluregn @CKEditorBot