[NT-876] Add Pledge CTA to ProjectDescriptionViewController #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
changed the base branch from
master
to
NT-872-feature-project-page-experiment
cdolm92
suggested changes
Feb 19, 2020
| self.pledgeCTAButtonTappedProperty.value = state | ||
| } | ||
|
|
||
| fileprivate let projectProperty = MutableProperty<(Project, RefTag?)?>(nil) |
There was a problem hiding this comment.
Can this be renamed to projectAndReftagProperty?
| self?.pledgeCTAContainerView.configureWith(value: value) | ||
| } | ||
|
|
||
| self.pledgeCTAContainerView.rac.hidden = self.viewModel.outputs.pledgeCTAContainerViewIsHidden |
There was a problem hiding this comment.
can we put this at the very top of bindViewModel(), after super.bindViewModel(). Same with line 92.
1 task
nativeksr
reviewed
Feb 20, 2020
| @@ -36,7 +38,7 @@ internal final class ProjectPamphletContentDataSource: ValueCellDataSource { | |||
| ) | |||
| } | |||
|
|
|||
| self.set(values: [project], cellClass: ProjectPamphletMainCell.self, inSection: Section.main.rawValue) | |||
| self.set(values: [projectAndRefTag], cellClass: ProjectPamphletMainCell.self, inSection: Section.main.rawValue) | |||
There was a problem hiding this comment.
| 🚫 | Line should be 110 characters or less: currently 115 charactersline_length ProjectPamphletContentDataSource.swift:41 |
nativeksr
reviewed
Feb 20, 2020
| .filter { _, subpage, _ in subpage == .comments } | ||
| .map { project, _, vcs in vcs + [CommentsViewController.configuredWith(project: project, update: nil)] } | ||
| .filter { _, subpage, _, _ in subpage == .comments } | ||
| .map { project, _, vcs, _ in vcs + [CommentsViewController.configuredWith(project: project, update: nil)] } |
There was a problem hiding this comment.
| 🚫 | Line should be 110 characters or less: currently 113 charactersline_length AppDelegateViewModel.swift:457 |
Generated by 🚫 Danger |
3 tasks
cdolm92
approved these changes
Feb 20, 2020
* Pop project pamphlet to root VC after project is backed * Alphabetize
…k-project-campaign-details # Conflicts: # Library/ViewModels/ProjectPamphletMainCellViewModelTests.swift
This was referenced Feb 21, 2020
justinswart
added a commit
that referenced
this pull request
Mar 4, 2020
* [NT-878, NT-873] Add Experiment and Read More is a full-width button (#1073) * read more button experiment * testing experiment outputs * swift format * naming changes * new snapshots * feedback * swift format * corrected typo * [NT-876] Add Pledge CTA to ProjectDescriptionViewController (#1072) * Add pledge CTA to project description * Update tests * Add goToRewards to ProjectDescriptionViewController * Tidy up * Tidy up * Fix line lengths * [NT-876] Pop ProjectPamphlet to root after project is backed (#1075) * Pop project pamphlet to root VC after project is backed * Alphabetize * [NT-876] Add Project Campaign Experiment Tests (#1076) * Add tests * Fix tests * Remove duplicate * Hide the back this project button to creators of their own projects (#1078) * [NT-877] Project page Optimizely Events (#1079) * optimizely tracking events * swiftlint fix * swift format * Add loader to read more button in second variant (#1077) Co-authored-by: Christella <cdolm92@gmail.com>
ifbarrera
pushed a commit
that referenced
this pull request
Mar 18, 2020
* [NT-878, NT-873] Add Experiment and Read More is a full-width button (#1073) * [NT-876] Add Pledge CTA to ProjectDescriptionViewController (#1072) * [NT-876] Pop ProjectPamphlet to root after project is backed (#1075) * [NT-876] Add Project Campaign Experiment Tests (#1076) * Hide the back this project button to creators of their own projects (#1078) * [NT-877] Project page Optimizely Events (#1079) * Add loader to read more button in second variant (#1077) * [NT-930] Add Project Creator Details Query and VM outputs (#1086) * [NT-940] Activate Creator Details Experiment (#1088) * [NT-931] Add creator byline view (#1089) Co-authored-by: Justin Swart <justinswart@users.noreply.github.com> * [NT- 956] CreatorByline View Model and Tests (#1095) * [NT-937] Creator Details Shimmer Loading View (#1097) * [NT- 939] Creator details tracking events (#1098) * translated copy (#1111) Co-authored-by: Christella <cdolm92@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Displays the pledge button on our campaign details page when the user is part of that experiment group.
Note: In order to reduce the size of this PR I have added some TODOs that will be in separate PRs.
🤔 Why
This work is part of our experimentation to test whether we can increase conversion from the campaign details page.
🛠 How
PledgeCTAContainerViewtoProjectDescriptionViewController.RewardsViewControllerfromProjectDescriptionViewController.RefTagthrough toProjectDescriptionViewController.👀 See
✅ Acceptance criteria
On the Project view tap on Read more about the campaign:
⏰ TODO
TODOs which will add tests once the experimentation code is merged.