[NT-940] Activate Creator Details Experiment #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…activate-creator-details-variant # Conflicts: # Library/ViewModels/ProjectPamphletContentViewModel.swift # Library/ViewModels/ProjectPamphletContentViewModelTests.swift
cdolm92
suggested changes
Mar 2, 2020
Library/OptimizelyExperiment.swift
Outdated
| @@ -5,6 +5,7 @@ public enum OptimizelyExperiment { | |||
| public enum Key: String { | |||
| case pledgeCTACopy = "pledge_cta_copy" | |||
| case nativeProjectPageCampaignDetails = "native_project_page_campaign_details" | |||
| case projectPageConversionCreatorDetails = "project_page_conversion_creator_details" | |||
There was a problem hiding this comment.
Looks like the name of the experiment is native_project_page_conversion_creator_details
nativeksr
reviewed
Mar 2, 2020
| withEnvironment(apiService: mockService) { | ||
| let optimizelyClient = MockOptimizelyClient() | ||
| |> \.experiments .~ [ | ||
| OptimizelyExperiment.Key.nativeProjectPageConversionCreatorDetails.rawValue: OptimizelyExperiment.Variant.variant1.rawValue |
There was a problem hiding this comment.
| 🚫 | Line should be 110 characters or less: currently 131 charactersline_length ProjectPamphletContentViewModelTests.swift:410 |
nativeksr
reviewed
Mar 2, 2020
|
|
||
| let optimizelyClient = MockOptimizelyClient() | ||
| |> \.experiments .~ [ | ||
| OptimizelyExperiment.Key.nativeProjectPageConversionCreatorDetails.rawValue: OptimizelyExperiment.Variant.control.rawValue |
There was a problem hiding this comment.
| 🚫 | Line should be 110 characters or less: currently 130 charactersline_length ProjectPamphletContentViewModelTests.swift:488 |
nativeksr
reviewed
Mar 2, 2020
|
|
||
| let optimizelyClient = MockOptimizelyClient() | ||
| |> \.experiments .~ [ | ||
| OptimizelyExperiment.Key.nativeProjectPageConversionCreatorDetails.rawValue: OptimizelyExperiment.Variant.variant1.rawValue |
There was a problem hiding this comment.
| 🚫 | Line should be 110 characters or less: currently 131 charactersline_length ProjectPamphletContentViewModelTests.swift:633 |
ifbarrera
pushed a commit
that referenced
this pull request
Mar 18, 2020
* [NT-878, NT-873] Add Experiment and Read More is a full-width button (#1073) * [NT-876] Add Pledge CTA to ProjectDescriptionViewController (#1072) * [NT-876] Pop ProjectPamphlet to root after project is backed (#1075) * [NT-876] Add Project Campaign Experiment Tests (#1076) * Hide the back this project button to creators of their own projects (#1078) * [NT-877] Project page Optimizely Events (#1079) * Add loader to read more button in second variant (#1077) * [NT-930] Add Project Creator Details Query and VM outputs (#1086) * [NT-940] Activate Creator Details Experiment (#1088) * [NT-931] Add creator byline view (#1089) Co-authored-by: Justin Swart <justinswart@users.noreply.github.com> * [NT- 956] CreatorByline View Model and Tests (#1095) * [NT-937] Creator Details Shimmer Loading View (#1097) * [NT- 939] Creator details tracking events (#1098) * translated copy (#1111) Co-authored-by: Christella <cdolm92@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Activates the
project_page_conversion_creator_detailsexperiment.🤔 Why
A continuation of the work in #1086, this conditionally activates the experiment if the fetching of the project creator details succeeds.
🛠 How
✅ Acceptance criteria
Navigate to a project page.
fetchProjectCreatorDetailsfails and you are invariant1the VM should output(nil, true)forProjectCreatorDetailsData.fetchProjectCreatorDetailssucceeds and you are invariant1the VM should output(result, true)forProjectCreatorDetailsData.controlgroup, the VM should output(nil, true)forProjectCreatorDetailsData.