[NT-863] Creator Details Experiment #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1073) * read more button experiment * testing experiment outputs * swift format * naming changes * new snapshots * feedback * swift format * corrected typo
* Add pledge CTA to project description * Update tests * Add goToRewards to ProjectDescriptionViewController * Tidy up * Tidy up * Fix line lengths * [NT-876] Pop ProjectPamphlet to root after project is backed (#1075) * Pop project pamphlet to root VC after project is backed * Alphabetize
* Add tests * Fix tests * Remove duplicate
* optimizely tracking events * swiftlint fix * swift format
* Add ProjectCreatorDetailsEnvelope * Add projectCreatorDetailsQuery * Add request and datasource output * Fix query * Line length * Revert vm change * swiftlint
* Add ProjectCreatorDetailsEnvelope * Add projectCreatorDetailsQuery * Add request and datasource output * Fix query * Line length * Revert vm change * swiftlint * Add experiment activation * Rename experiment * swiftlint
* creator byline view * swift format * swift lint fix * fix creator byline placement * swift format * creatorbyline output * Layout simplification * pr feedback and other improvements * swift format * removed unused code * pr feedback * remove lens Co-authored-by: Justin Swart <justinswart@users.noreply.github.com>
# Conflicts: # Kickstarter-iOS/DataSources/ProjectPamphletContentDataSource.swift # Kickstarter-iOS/DataSources/ProjectPamphletContentDataSourceTests.swift # Kickstarter-iOS/Views/Cells/ProjectPamphletMainCell.swift # Kickstarter-iOS/Views/Controllers/ProjectPamphletContentViewController.swift # Library/OptimizelyExperiment.swift # Library/ViewModels/ProjectPamphletContentViewModel.swift # Library/ViewModels/ProjectPamphletContentViewModelTests.swift # Library/ViewModels/ProjectPamphletMainCellViewModel.swift
4 tasks
* creator byline view * swift format * swift lint fix * fix creator byline placement * swift format * creatorbyline output * pr feedback and other improvements * swift format * removed unused code * new copy * removed string * creator data * pr feedback * tests * refactor * format int and swiftlint fix * swift format * remove string * hid creatorbyline * projectcreator template * pr feedback
Generated by 🚫 Danger |
* Add shimmer view to ProjectPamphletMainCell * hide shimmer * Add view model bindings * Fix snapshots
* creator byline view * swift format * swift lint fix * fix creator byline placement * swift format * creatorbyline output * pr feedback and other improvements * swift format * removed unused code * new copy * removed string * creator data * pr feedback * tests * refactor * format int and swiftlint fix * swift format * remove string * hid creatorbyline * projectcreator template * pr feedback * tracking events and showing byline * pr feedback * fix test * pr feedback * swift format
ifbarrera
approved these changes
Mar 18, 2020
4 tasks
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Feature branch to track the work completed in #1086, #1088, #1089, #1095, #1097, #1098 which introduces an A/B experiment into the app to display trust indicators and creator details on the project page.
🤔 Why
As part of an experiment that we are running we would like to display some additional data to surface trust indicators to users.
👀 See