[NT-930] Add Project Creator Details Query and VM outputs #1086

justinswart · 2020-02-27T01:28:33Z

📲 What

Adds a query for us to fetch some additional project creator details from GraphQL when a project page loads.

Note: This emits what we expect to need to configure the cell that will display this data, that is the ProjectCreatorDetailsEnvelope result and an isLoading boolean to indicate whether we are still fetching the results.

🤔 Why

As part of an experiment that we are running we would like to display some additional data to surface trust indicators to users. These values are not available from the v1 API so we are fetching them from GraphQL.

🛠 How

Added ProjectCreatorDetailsEnvelope.
Added fetchProjectCreatorDetails to ServiceType.
Added some types to ProjectPamphletContentViewModel to improve the frequently changing interface of its datasource loading output.
Updated GraphSchema.
Added tests.

✅ Acceptance criteria

Upon a project page loading observe that (nil, true) is emitted to put the cell in an initial loading state.
Once the GraphQL request successfully completes observe that (result, false) is emitted.
If the request fails observe that (nil, false) is emitted.

justinswart · 2020-02-27T01:30:49Z

Kickstarter-iOS/DataSources/ProjectPamphletContentDataSource.swift

@@ -39,7 +39,7 @@ internal final class ProjectPamphletContentDataSource: ValueCellDataSource {
    }

    self.set(
-      values: [projectAndRefTag],
+      values: [(project, refTag)],


We will update ProjectPamphletMainCell to be configured with all three values (or just ProjectPamphletContentData).

justinswart · 2020-02-27T01:32:56Z

KsApi/MockService.swift

    fileprivate let fetchProjectsResponse: [Project]?
    fileprivate let fetchProjectsError: ErrorEnvelope?

+    fileprivate let fetchProjectCreatorDetailsResult: Result<ProjectCreatorDetailsEnvelope, GraphError>?
+
+    fileprivate let fetchProjectNotificationsResponse: [ProjectNotification]


Alphabetized this so it moved around in a few places. But I now realize a bunch of things are still out of place so I might revert this change and rather fix the ordering separately.

justinswart · 2020-02-27T01:37:29Z

Library/ViewModels/ProjectPamphletContentViewModel.swift

+          .ksr_delay(AppEnvironment.current.apiDelayInterval, on: AppEnvironment.current.scheduler)
+          .map { result in (result, false) }
+          .prefix(value: (nil, true))
+          .demoteErrors(replaceErrorWith: (nil, false))


If this errors out we just return nil and tell the cell to stop loading. We will do additional work to not even activate the experiment if we don't have this data.

nativeksr · 2020-02-27T18:04:53Z

KsApi/Service.swift

@@ -306,6 +302,14 @@ public struct Service: ServiceType {
    return requestPagination(paginationUrl)
  }

+  public func fetchProjectCreatorDetails(query: NonEmptySet<Query>) -> SignalProducer<ProjectCreatorDetailsEnvelope, GraphError> {


🚫 Line should be 110 characters or less: currently 130 characters
line_length Service.swift:305

nativeksr · 2020-02-27T18:04:55Z

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

nativeksr · 2020-02-27T18:04:54Z

Library/ViewModels/ProjectPamphletContentViewModelTests.swift

+      self.loadProjectIntoDataSourceProject
+        .assertValues([project], "Load the full project into the data source.")
+      self.loadProjectIntoDataSourceRefTag.assertValues([.discovery], "Load the refTag into the data source.")
+      self.loadMinimalProjectIntoDataSource.assertValues([], "Do not load the minimal version of the project.")


🚫 Line should be 110 characters or less: currently 111 characters
line_length ProjectPamphletContentViewModelTests.swift:501

Scollaco

Looks good! I just have a couple questions. Also it seems that there are some Line Length violations.

Scollaco · 2020-02-27T19:25:10Z

KsApi/GraphSchema.swift

@@ -192,17 +193,18 @@ public enum Query {
    }
  }

-  public enum User {
+  public indirect enum User {


Is there a reason why we are enabling indirection for all cases?

I think this is because of the recursive relationship between Project <-> User. Without this it gives this error:

Scollaco · 2020-02-27T19:41:46Z

Library/ViewModels/ProjectPamphletContentViewModelTests.swift

@@ -6,30 +6,39 @@ import ReactiveSwift
 import XCTest

 final class ProjectPamphletContentViewModelTests: TestCase {
-  fileprivate let vm: ProjectPamphletContentViewModelType = ProjectPamphletContentViewModel()
+  fileprivate var vm: ProjectPamphletContentViewModelType!


Is this change necessary? 🤔

Nope! Sometimes it is for the scheduler to work correctly but in this case it wasn't. Thanks 👍

Scollaco

* [NT-878, NT-873] Add Experiment and Read More is a full-width button (#1073) * [NT-876] Add Pledge CTA to ProjectDescriptionViewController (#1072) * [NT-876] Pop ProjectPamphlet to root after project is backed (#1075) * [NT-876] Add Project Campaign Experiment Tests (#1076) * Hide the back this project button to creators of their own projects (#1078) * [NT-877] Project page Optimizely Events (#1079) * Add loader to read more button in second variant (#1077) * [NT-930] Add Project Creator Details Query and VM outputs (#1086) * [NT-940] Activate Creator Details Experiment (#1088) * [NT-931] Add creator byline view (#1089) Co-authored-by: Justin Swart <justinswart@users.noreply.github.com> * [NT- 956] CreatorByline View Model and Tests (#1095) * [NT-937] Creator Details Shimmer Loading View (#1097) * [NT- 939] Creator details tracking events (#1098) * translated copy (#1111) Co-authored-by: Christella <cdolm92@gmail.com>

justinswart added 3 commits February 26, 2020 14:18

Add ProjectCreatorDetailsEnvelope

57e3cd1

Add projectCreatorDetailsQuery

85ab1ab

Add request and datasource output

555897a

justinswart requested review from Scollaco and cdolm92 February 27, 2020 01:28

justinswart assigned Scollaco Feb 27, 2020

justinswart commented Feb 27, 2020

View reviewed changes

Fix query

a8f032c

nativeksr reviewed Feb 27, 2020

View reviewed changes

Scollaco reviewed Feb 27, 2020

View reviewed changes

justinswart added 3 commits February 27, 2020 11:48

Line length

40e66e7

Revert vm change

c6ccc0f

swiftlint

4bf057d

Scollaco approved these changes Feb 27, 2020

View reviewed changes

justinswart merged commit b511e61 into NT-863-feature-creator-details-experiment Feb 27, 2020

justinswart deleted the NT-930-add-project-creator-details-query branch February 27, 2020 23:47

This was referenced Feb 28, 2020

[NT-940] Activate Creator Details Experiment #1088

Merged

[NT-863] Creator Details Experiment #1093

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NT-930] Add Project Creator Details Query and VM outputs #1086

[NT-930] Add Project Creator Details Query and VM outputs #1086

justinswart commented Feb 27, 2020

justinswart Feb 27, 2020

justinswart Feb 27, 2020

justinswart Feb 27, 2020

nativeksr Feb 27, 2020 •

edited

Loading

nativeksr commented Feb 27, 2020

nativeksr Feb 27, 2020

Scollaco left a comment

Scollaco Feb 27, 2020

justinswart Feb 27, 2020

Scollaco Feb 27, 2020

justinswart Feb 27, 2020

Scollaco left a comment

[NT-930] Add Project Creator Details Query and VM outputs #1086

[NT-930] Add Project Creator Details Query and VM outputs #1086

Conversation

justinswart commented Feb 27, 2020

📲 What

🤔 Why

🛠 How

✅ Acceptance criteria

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nativeksr Feb 27, 2020 • edited Loading

Choose a reason for hiding this comment

nativeksr commented Feb 27, 2020

Choose a reason for hiding this comment

Scollaco left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Scollaco left a comment

Choose a reason for hiding this comment

nativeksr Feb 27, 2020 •

edited

Loading