Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add wave body total power to latent data #165

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Sep 19, 2023

@andermi andermi changed the base branch from andermi/latent_data to main September 19, 2023 23:05
@andermi andermi changed the base branch from main to andermi/latent_data September 19, 2023 23:05
@hamilton8415
Copy link
Collaborator

Looks good, it's hard to verify that the powers are correct, and one can see that the leading order term of the excitation force is the opposite of the buoyancy force, as it should be in this linear theory. Makes it a bit hard for either one to have meaning without the other, but I think we should leave it this way as that's usually how these things are represented.

We may want to add the position and velocity of the buoy to this message, i.e. w_Pose_p for the position, and w_xdot_p and w_omega_p for the velocities. I think that could be useful information for a number of things.

Also, since we're here, it'd be great to include the local incident wave height that's being used to compute the exciting force. Looks like I did some trickery so that the exciting force computation figures out what that is on it's own, so there isn't an explicit assignment. Looking at that it's computed as " _IncWave->eta(0, 0, t);" in the wave-exciting force code, and we have that incident wave object so should be easy to get it. Note that it has to be called at x=0,y=0. This isn't very satisfying, but how it has to be, it basically means the origin of the wave-field is moving around with the buoy, and a point to discuss related to WecSIM, I am not sure how they handle the issue but it could be related to the slight phase difference we see when comparing results.

Anyway, I am also happy to add these last features if desired.

@hamilton8415
Copy link
Collaborator

Right, and immediately after hitting send, I remember that we already have the capability to show the wave-height data. Showing that at the buoy origin should do the trick, so maybe we can leave it at that.

@andermi
Copy link
Collaborator Author

andermi commented Sep 20, 2023

I added
pose: position, orientation
twist: linear/angular velocities

Signed-off-by: Michael Anderson <anderson@mbari.org>
Signed-off-by: Michael Anderson <anderson@mbari.org>
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
Copy link
Collaborator Author

andermi commented Sep 20, 2023

and like you said, we have the wave height at the buoy position being reported in latent data by default

@andermi
Copy link
Collaborator Author

andermi commented Sep 20, 2023

should I do anything with the WaterplaneOrigin (b_Pose_p) ? it's hardcoded to (0.0, 0.0, 2.45) above the buoy link origin

@hamilton8415
Copy link
Collaborator

I don't think anything is neccessary, that location is where the buoyancy force balances the weight. If it's off, there's no big effect other than in calm water there's a steady-state buoy dispaclement to account for the difference.

@andermi
Copy link
Collaborator Author

andermi commented Sep 20, 2023

I think this is ready to go then

Copy link
Collaborator

@hamilton8415 hamilton8415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs and looks good to me.

@andermi andermi merged commit fbe8a5d into andermi/latent_data Sep 21, 2023
0 of 2 checks passed
@andermi andermi deleted the hamilton_8415/wavebody_latent_data branch September 21, 2023 19:30
andermi added a commit that referenced this pull request Sep 21, 2023
* update spring to match at-sea polytropic process

Signed-off-by: Michael Anderson <anderson@mbari.org>

* can now specify spring params per batch

Signed-off-by: Michael Anderson <anderson@mbari.org>

* tune spring to match atsea

Signed-off-by: Michael Anderson <anderson@mbari.org>

* ros2 service for incwave height; issues so replace LinearIncidentWave with non-pointer in ECM

Signed-off-by: Michael Anderson <anderson@mbari.org>

* use parent folder for FreeSurfaceHydrodynamics includes

Signed-off-by: Michael Anderson <anderson@mbari.org>

* add matrix_mode: False option to sim params yaml to allow vectorized mode

Signed-off-by: Michael Anderson <anderson@mbari.org>

* added latent data and tweaked incwaveheight

Signed-off-by: Michael Anderson <anderson@mbari.org>

* can specify incwaveheight points in sdf

Signed-off-by: Michael Anderson <anderson@mbari.org>

* added spring and pto (still need a couple pto losses)

Signed-off-by: Michael Anderson <anderson@mbari.org>

* linters

Signed-off-by: Michael Anderson <anderson@mbari.org>

* linters

Signed-off-by: Michael Anderson <anderson@mbari.org>

* add ehpto force

Signed-off-by: Michael Anderson <anderson@mbari.org>

* added forces from piston friction and wavebodyinteraction

Signed-off-by: Michael Anderson <anderson@mbari.org>

* Debug flag for WaveBodyInteractions plugin (#160)

* temporarily checkout andermi/latent_data in mbari_wec_utils for CI

Signed-off-by: Michael Anderson <anderson@mbari.org>

* linters

Signed-off-by: Michael Anderson <anderson@mbari.org>

* add gas mass and eff_v/m; comment units; use buoy_utils/constants.h in spring

Signed-off-by: Michael Anderson <anderson@mbari.org>

* fix last push

Signed-off-by: Michael Anderson <anderson@mbari.org>

* fix latent_data pub

Signed-off-by: Michael Anderson <anderson@mbari.org>

* Added Shaft Mechanical Power to Latent Data

* Added additional loss terms to electrohydraulic latent data

* Resolved signs with supplied hydraulic power

* Fixed bug in relief valve loss computation

* Adjusted fields

* Fixed formating for linters

* Add wave body total power to latent data (#165)

* added wave_body total forces

Signed-off-by: Michael Anderson <anderson@mbari.org>

* added buoy pose and twist to latent data

Signed-off-by: Michael Anderson <anderson@mbari.org>

* added pose/twist to operator== for latent data

Signed-off-by: Michael Anderson <anderson@mbari.org>

* init pose/twist

Signed-off-by: Michael Anderson <anderson@mbari.org>

* linters

Signed-off-by: Michael Anderson <anderson@mbari.org>

---------

Signed-off-by: Michael Anderson <anderson@mbari.org>

---------

Signed-off-by: Michael Anderson <anderson@mbari.org>
Co-authored-by: Andrew Hamilton <hamilton@mbari.org>
Co-authored-by: Andrew Hamilton <62493321+hamilton8415@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants