Skip to content

Stabilize Ready::into_inner() #116528

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2024
Merged

Stabilize Ready::into_inner() #116528

merged 1 commit into from
Aug 17, 2024

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Oct 8, 2023

This PR stabilizes Ready::into_inner().

Tracking issue: #101196.
Implementation PR: #101189.

Closes #101196.

@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 8, 2023
@daxpedda daxpedda mentioned this pull request Oct 8, 2023
Closed
3 tasks
@cuviper
Copy link
Member

cuviper commented Oct 9, 2023

@rustbot label -T-libs +T-libs-api
r? libs-api

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 9, 2023
@rustbot rustbot assigned dtolnay and unassigned cuviper Oct 9, 2023
@dtolnay
Copy link
Member

dtolnay commented Oct 10, 2023

FCP proposed: #101196 (comment)

@dtolnay dtolnay added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2023
daxpedda
daxpedda commented Dec 19, 2023
View reviewed changes
@dtolnay dtolnay added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Mar 30, 2024
@Dylan-DPC Dylan-DPC added the S-tracking-design-concerns Status: There are blocking design concerns. label Apr 10, 2024
@daxpedda daxpedda force-pushed the stabilize-ready-into-inner branch from 1800c0c to 0732f7d Compare August 7, 2024 22:18
@daxpedda
Copy link
Contributor Author

daxpedda commented Aug 7, 2024

Going by the latest discussion I went ahead and reverted the renaming.

@dtolnay dtolnay removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Aug 16, 2024
dtolnay
dtolnay approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented Aug 16, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 16, 2024

📌 Commit 0732f7d has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 16, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 16, 2024
@matthiaskrgr
Rollup merge of rust-lang#116528 - daxpedda:stabilize-ready-into-inne…
c4d473c 
…r, r=dtolnay

Stabilize `Ready::into_inner()`

This PR stabilizes `Ready::into_inner()`.

Tracking issue: rust-lang#101196.
Implementation PR: rust-lang#101189.

Closes rust-lang#101196.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 16, 2024
Closed
@bors
Copy link
Collaborator

bors commented Aug 16, 2024

⌛ Testing commit 0732f7d with merge 67d0973...

@bors
Copy link
Collaborator

bors commented Aug 17, 2024

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 67d0973 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 17, 2024
@bors bors merged commit 67d0973 into rust-lang:master Aug 17, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 17, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (67d0973): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.6% [3.2%, 4.1%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 750.072s -> 750.979s (0.12%)
Artifact size: 339.23 MiB -> 339.14 MiB (-0.03%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. S-tracking-design-concerns Status: There are blocking design concerns. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for Ready::into_inner()
7 participants
@daxpedda @rustbot @cuviper @dtolnay @bors @rust-timer @Dylan-DPC