Skip to content

Add missing read_buf stub for x86_64-unknown-l4re-uclibc #129913

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

saethlin
Copy link
Member

@saethlin saethlin commented Sep 2, 2024

Before this PR, x check library/std --target x86_64-unknown-l4re-uclibc will fail with

error[E0599]: no method named `read_buf` found for struct `Socket` in the current scope
   --> std/src/os/unix/net/stream.rs:598:16
    |
598 |         self.0.read_buf(buf)
    |                ^^^^^^^^
    |
   ::: std/src/sys/pal/unix/l4re.rs:23:5
    |
23  |     pub struct Socket(FileDesc);
    |     ----------------- method `read_buf` not found for this struct
    |
    = help: items from traits can only be used if the trait is implemented and in scope

This target doesn't have a maintainer to cc.

@saethlin saethlin added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 2, 2024
@saethlin saethlin changed the title Add missing read_buf stub for x86_64-unknown-l5re-uclibc Add missing read_buf stub for x86_64-unknown-l4re-uclibc Sep 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2024
@Noratrieb
Copy link
Member

if it doesn't have a maintainer to cc, maybe it's time for it to go :3 (and if someone complains they can become the maintainer).
when was this added?

@Noratrieb
Copy link
Member

in #43639. #112595 was the most recent specific change.

@Noratrieb
Copy link
Member

@hargoniX I see you've contributed a fix to the l4re target within the last year. do you still use this target and if yes, would you be interested in becoming a target maintainer (see the target tier policy for what to expect).
if no maintainer is found, the target might be removed in the future.

@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 2, 2024

📌 Commit fcb7d3f has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#129152 (custom/external clippy support for bootstrapping)
 - rust-lang#129311 (don't copy `.rustc-dev-contents` from CI rustc)
 - rust-lang#129800 (Move the Windows remove_dir_all impl into a module and make it more race resistant)
 - rust-lang#129860 (update `object` dependency to remove duplicate `wasmparser`)
 - rust-lang#129885 (chore: remove repetitive words)
 - rust-lang#129913 (Add missing read_buf stub for x86_64-unknown-l4re-uclibc)
 - rust-lang#129916 (process.rs: remove "Basic usage" text where not useful)
 - rust-lang#129917 (Fix parsing of beta version in dry-run mode)

r? `@ghost`
`@rustbot` modify labels: rollup
@hargoniX
Copy link
Member

hargoniX commented Sep 3, 2024

@hargoniX I see you've contributed a fix to the l4re target within the last year. do you still use this target and if yes, would you be interested in becoming a target maintainer (see the target tier policy for what to expect). if no maintainer is found, the target might be removed in the future.

Unfortunately not. It was a project for my Bachelor thesis and I've since moved on to other ones. Maybe @humenda is interested or knows somebody that is interested?

@bors bors merged commit f943c53 into rust-lang:master Sep 3, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2024
Rollup merge of rust-lang#129913 - saethlin:l4re-read-buf, r=Noratrieb

Add missing read_buf stub for x86_64-unknown-l4re-uclibc

Before this PR, `x check library/std --target x86_64-unknown-l4re-uclibc` will fail with
```
error[E0599]: no method named `read_buf` found for struct `Socket` in the current scope
   --> std/src/os/unix/net/stream.rs:598:16
    |
598 |         self.0.read_buf(buf)
    |                ^^^^^^^^
    |
   ::: std/src/sys/pal/unix/l4re.rs:23:5
    |
23  |     pub struct Socket(FileDesc);
    |     ----------------- method `read_buf` not found for this struct
    |
    = help: items from traits can only be used if the trait is implemented and in scope
```

This target doesn't have a maintainer to cc.
@saethlin saethlin deleted the l4re-read-buf branch September 3, 2024 14:10
@humenda
Copy link
Contributor

humenda commented Sep 4, 2024 via email

@farao
Copy link

farao commented Nov 19, 2024

Hi, Marius from Kernkonzept here. Yes, I'd like to step in here. How do you become a maintainer for a target? I'm actually currently doing changes to how the linking of rust for l4re is done (without the need of the l4-bender wrapper script which is using meta information from the l4re build) and I will provide a PR soon.

@saethlin
Copy link
Member Author

The target in question doesn't have a documentation page, so the first thing is to add one. You'll be adjusting this line:

`x86_64-unknown-l4re-uclibc` | ? | |
to be a link like the surrounding lines, then actually providing a target for that link in platform-support. I don't think we have an actual template, but starting by copying from a similar target is probably good.

The important thing is that there's a page and it mentions you and your GitHub account so people can get in touch when there's a problem.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants