-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add missing read_buf stub for x86_64-unknown-l4re-uclibc #129913
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
if it doesn't have a maintainer to cc, maybe it's time for it to go :3 (and if someone complains they can become the maintainer). |
@hargoniX I see you've contributed a fix to the l4re target within the last year. do you still use this target and if yes, would you be interested in becoming a target maintainer (see the target tier policy for what to expect). |
@bors r+ rollup |
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#129152 (custom/external clippy support for bootstrapping) - rust-lang#129311 (don't copy `.rustc-dev-contents` from CI rustc) - rust-lang#129800 (Move the Windows remove_dir_all impl into a module and make it more race resistant) - rust-lang#129860 (update `object` dependency to remove duplicate `wasmparser`) - rust-lang#129885 (chore: remove repetitive words) - rust-lang#129913 (Add missing read_buf stub for x86_64-unknown-l4re-uclibc) - rust-lang#129916 (process.rs: remove "Basic usage" text where not useful) - rust-lang#129917 (Fix parsing of beta version in dry-run mode) r? `@ghost` `@rustbot` modify labels: rollup
Unfortunately not. It was a project for my Bachelor thesis and I've since moved on to other ones. Maybe @humenda is interested or knows somebody that is interested? |
Rollup merge of rust-lang#129913 - saethlin:l4re-read-buf, r=Noratrieb Add missing read_buf stub for x86_64-unknown-l4re-uclibc Before this PR, `x check library/std --target x86_64-unknown-l4re-uclibc` will fail with ``` error[E0599]: no method named `read_buf` found for struct `Socket` in the current scope --> std/src/os/unix/net/stream.rs:598:16 | 598 | self.0.read_buf(buf) | ^^^^^^^^ | ::: std/src/sys/pal/unix/l4re.rs:23:5 | 23 | pub struct Socket(FileDesc); | ----------------- method `read_buf` not found for this struct | = help: items from traits can only be used if the trait is implemented and in scope ``` This target doesn't have a maintainer to cc.
I'm unfortunately not working on L4Re anymore. However, I've pinged
Kernkonzept, company behind L4Re, and I hope they can appoint a maintainer.
|
Hi, Marius from Kernkonzept here. Yes, I'd like to step in here. How do you become a maintainer for a target? I'm actually currently doing changes to how the linking of rust for l4re is done (without the need of the l4-bender wrapper script which is using meta information from the l4re build) and I will provide a PR soon. |
The target in question doesn't have a documentation page, so the first thing is to add one. You'll be adjusting this line: rust/src/doc/rustc/src/platform-support.md Line 389 in 7d40450
platform-support . I don't think we have an actual template, but starting by copying from a similar target is probably good.
The important thing is that there's a page and it mentions you and your GitHub account so people can get in touch when there's a problem. |
Before this PR,
x check library/std --target x86_64-unknown-l4re-uclibc
will fail withThis target doesn't have a maintainer to cc.