meshcat_visualizer: force type of image paths to pathlib.Path #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:
- build_collision (build Pinocchio with coal support)
- build_casadi (build Pinocchio with CasADi support)
- build_autodiff (build Pinocchio with CppAD support)
- build_codegen (build Pinocchio with CppADCodeGen support)
- build_extra (build Pinocchio with extra algorithms)
- build_mpfr (build Pinocchio with Boost.Multiprecision support)
- build_sdf (build Pinocchio with SDF parser)
- build_accelerate (build Pinocchio with APPLE Accelerate framework support)
- build_all (build Pinocchio with ALL the options stated above)
Thanks.
The Pinocchio development team.
|
Can you add a little line in the CHANGELOG ? |
jcarpent
approved these changes
Nov 15, 2024
jorisv
approved these changes
Nov 15, 2024
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Dec 19, 2024
## What's Changed
### Added
- Add `pinocchio_python_parser` target (stack-of-tasks/pinocchio#2475)
### Fixed
- Fix mjcf parsing of armature and of the default tag in models (stack-of-tasks/pinocchio#2477)
- Fix undefined behavior when using the site attribute in mjcf (stack-of-tasks/pinocchio#2477)
- Fix the type of image paths when loading textures in the meshcat visualizer (stack-of-tasks/pinocchio#2478)
- Fix meshcat examples (stack-of-tasks/pinocchio#2503)
- Fix `pinocchio-test-cpp-parallel-geometry` when built with Coal (stack-of-tasks/pinocchio#2502)
- Fix scaling support for meshcat (stack-of-tasks/pinocchio#2511)
### Changed
- On GNU/Linux and macOS, hide all symbols by default (stack-of-tasks/pinocchio#2469)
**Full Changelog**: stack-of-tasks/pinocchio@v3.3.0...v3.3.1
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the following error while using the meshcat visualizer:
Therefore I forced the type to
Path. This is coherent with thePath(img_path_abs).open("rb")two lines below.