Fix meshcat examples #2503
Merged
Fix meshcat examples #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix #2487 |
|
It's totally normal, the meshcat visualizer's startup of its server is non blocking, so your script MAY exit before the server got spun up and your browser tab opens. You should run your script with |
|
Ok, thank you for the explanation ! |
|
And there is no a blocking call in the API to wait for the viewer ? |
|
I don't think there is, apart from the method which tries to render an image (and I'm not sure the call terminates if the viewer is not already available). We could do a PR for this but nothing is happening upstream... |
jcarpent
approved these changes
Dec 7, 2024
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Dec 19, 2024
## What's Changed
### Added
- Add `pinocchio_python_parser` target (stack-of-tasks/pinocchio#2475)
### Fixed
- Fix mjcf parsing of armature and of the default tag in models (stack-of-tasks/pinocchio#2477)
- Fix undefined behavior when using the site attribute in mjcf (stack-of-tasks/pinocchio#2477)
- Fix the type of image paths when loading textures in the meshcat visualizer (stack-of-tasks/pinocchio#2478)
- Fix meshcat examples (stack-of-tasks/pinocchio#2503)
- Fix `pinocchio-test-cpp-parallel-geometry` when built with Coal (stack-of-tasks/pinocchio#2502)
- Fix scaling support for meshcat (stack-of-tasks/pinocchio#2511)
### Changed
- On GNU/Linux and macOS, hide all symbols by default (stack-of-tasks/pinocchio#2469)
**Full Changelog**: stack-of-tasks/pinocchio@v3.3.0...v3.3.1
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix meshcat examples.
meshcat-viewer-octree.pyused deprecated APImeshcat-viewer-solo.pyused example_robot_data, but this package can't be imported in PinocchioSome meshact examples where broken, but also, some display nothing except